[Koha-patches] [PATCH] Fixes bug 3326: escapes ampersands in itemcallnumber element of XML

[Galen Charlton]

Hi,

Why take out the test on whether $item->{itemcallnumber} was defined?
Doing so will cause a warning if the call number is null.

Regards,

Galen

On Tue, May 4, 2010 at 4:36 PM, Ian Walls
<ian.walls at bywatersolutions.com> wrote:
> From: Brendan A. Gallagher <brendan at bywatersolutions.com>
>
> Signed-off-by: Ian Walls <ian.walls at bywatersolutions.com>
> ---
>  C4/XSLT.pm |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/C4/XSLT.pm b/C4/XSLT.pm
> index f1fc9db..ccf6fc2 100644
> --- a/C4/XSLT.pm
> +++ b/C4/XSLT.pm
> @@ -206,10 +206,11 @@ sub buildKohaItemsNamespace {
>             $status = "available";
>         }
>         my $homebranch = $branches->{$item->{homebranch}}->{'branchname'};
> +        my $itemcallnumber = $item->{itemcallnumber};
> +        $itemcallnumber =~ s/\&/\&amp\;/g;
>         $xml.= "<item><homebranch>$homebranch</homebranch>".
>                "<status>$status</status>".
> -               (defined $item->{'itemcallnumber'} ? "<itemcallnumber>".$item->{'itemcallnumber'}."</itemcallnumber>"
> -                                           : "<itemcallnumber />")
> +               "<itemcallnumber>".$itemcallnumber."</itemcallnumber>"
>         . "</item>";
>
>     }
> --
> 1.5.6.5
>
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha.org
> http://lists.koha.org/mailman/listinfo/koha-patches
>



-- 
Galen Charlton
gmcharlt at gmail.com