[Koha-patches] [PATCH] Add TLS support to LDAP auth. Minor code refactor to clear up bind, search, compare distinction. TLS support requires IO::Socket::SSL, which has been added to dependencies

[Ian Walls]

Dobrica,


Yes, my mistake for not factoring in your bug fix for the Extended Patron
Attributes.  I was working on this concurrently with you, and must have
regressed that line in the rebase.  I can put that line back in and
resubmit.

It may be a matter of developer taste whether or not to die if there is no
mapping; I'm happy to add that clause back if the community agrees it should
be there.  If one is running without replicate or update, you won't need the
mapping, so requiring it may be unnecessary.

I would argue that the patch is not too large; there is a refactoring
involved to make it a little more understandable and extensible.  My goal
was to clearly sequence bind, search and (if necessary) compare, rather than
have those actions scattered throughout the code.  Starting a TLS connection
on top of LDAPS does require an extra command, so hence the addition to the
config XML.

Cheers,


-Ian


On Thu, May 13, 2010 at 3:47 PM, Galen Charlton <gmcharlt at gmail.com> wrote:

> Hi Dobrica,
>
> On Thu, May 13, 2010 at 3:38 PM, Dobrica Pavlinusic <dpavlin at rot13.org>
> wrote:
> > This let me to beleve that it's a simple diff between ByWaterSolutions
> > version of Auth_with_ldap.pm and latest community edition, without any
> > of fixes included in bug mentioned above.
>
> To clarify, your patches were pushed, as was noted in the bug, and it
> does look like Ian's patch is based against the current master.
>
> Regards,
>
> Galen
> --
> Galen Charlton
> gmcharlt at gmail.com
>



-- 
Ian Walls
Lead Development Specialist
ByWater Solutions
ALA Booth # 817
Phone # (888) 900-8944
http://bywatersolutions.com
ian.walls at bywatersolutions.com
Twitter: @sekjal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20100513/18cfec0f/attachment-0002.htm>