[Koha-patches] [PATCH] Bug 4514 (Error handling in 500.pl is erroneous itself)

[Marcel de Rooy]

The version in 3.0.x has only four parameters. The fourth is optional and defaults to text/html. The fifth is just ignored.
The 500 message comes from the template.
Do I oversee something?

-----Oorspronkelijk bericht-----
Van: Galen Charlton [mailto:gmcharlt at gmail.com] 
Verzonden: maandag 17 mei 2010 14:42
Aan: Marcel de Rooy
CC: koha-patches at lists.koha.org
Onderwerp: Re: [Koha-patches] [PATCH] Bug 4514 (Error handling in 500.pl is erroneous itself)

Hi,

On Mon, May 17, 2010 at 7:43 AM, Marcel de Rooy
<m.de.rooy at rijksmuseum.nl> wrote:
> -output_with_http_headers $query, $cookie, $template->output, 'html', '500 Internal Server Error';
> +output_html_with_http_headers $query, $cookie, $template->output; #, 'html', '500 Internal Server Error';
> +

Why comment out the content type and HTTP status arguments? Otherwise,
the script has no way of returning the correct status header.

Regards,

Galen
-- 
Galen Charlton
gmcharlt at gmail.com