[Koha-patches] [PATCH] Bug 4510 Script processes single supplier not an array

Galen Charlton gmcharlt at gmail.com
Mon May 17 16:07:24 CEST 2010


Hi,

On Sat, May 15, 2010 at 10:12 AM, Colin Campbell
<colin.campbell at ptfs-europe.com> wrote:
> Script was written as though it had an array rather than
> a single supplier. Replaced the excess punctuation with a single
> supplier variable
>
> replaced the C-style currency loop with a simpler perl-style one
> Changed variable name $GST to $tax it's not magical and not a constant
> and we all know what tax is
>
> removed use Contract which was generating errors as it redefined
> subroutines in the Acquisitions module
> removed introduction of unneeded variable to test contract returns

This patch introduces as new crash when I tested retrieving a vendor record:

supplier.pl: Can't use an undefined value as an ARRAY reference at
acqui/supplier.pl line 83.

This can be attributed to the removal of the 'use C4::Contract' line.
Please fix and resubmit.

Regards,

Galen
-- 
Galen Charlton
gmcharlt at gmail.com



More information about the Koha-patches mailing list