[Koha-patches] [PATCH] Remove generation of an unnecessary warning
Colin Campbell
colin.campbell at ptfs-europe.com
Wed May 19 16:00:09 CEST 2010
We've checked the return for definedness and
assigned an empty string to it ao we don't want
to make it undef again
This is a good argument that cascading if-elses expecially with
long unstructured elses are a bad idea
---
acqui/basket.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/acqui/basket.pl b/acqui/basket.pl
index 7c2456a..9381ae6 100755
--- a/acqui/basket.pl
+++ b/acqui/basket.pl
@@ -172,7 +172,7 @@ if ( $op eq 'delete_confirm' ) {
basketgroupname => $basket->{'basketname'});
}
-} elsif ($query->param('op') eq 'reopen') {
+} elsif ($op eq 'reopen') {
my $basket;
$basket->{basketno} = $query->param('basketno');
$basket->{closedate} = undef;
--
1.6.6.1
More information about the Koha-patches
mailing list