[Koha-patches] [PATCH] bug 4464: properly check if a subfield is populated if it is in a textarea

Galen Charlton gmcharlt at gmail.com
Fri May 21 19:00:58 CEST 2010


Subfields whose contents are longer than 100 characters are represented on the
bib form using a <textarea> instead of a text <input>.  The check on whether
at least one subfield for a mandatory field is populated wasn't not
checking for <textarea> subfields.

Signed-off-by: Galen Charlton <gmcharlt at gmail.com>
---
 .../prog/en/modules/cataloguing/addbiblio.tmpl     |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl
index 6c4a2c4..3e41f04 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tmpl
@@ -148,6 +148,14 @@ function AreMandatoriesNotOk(){
 					}
 	    		}
 	    	}
+
+	    	elemtextareas = elem.getElementsByTagName('textarea');
+	    	for(var j=0,len2=elemtextareas.length; j<len2; j++){
+                // this bit assumes that the only textareas in this context would be for subfields
+                if (elemtextareas[j].value) {
+                    isempty = false;
+                }
+            }
     	}else{
     		isempty = false;
     	}
-- 
1.7.0




More information about the Koha-patches mailing list