[Koha-patches] [PATCH] Improvements to smart-rules interface

Owen Leonard oleonard at myacpl.org
Wed May 26 21:03:19 CEST 2010


I propose some changes to the issuing rules interface to improve usability:

 - Rename the page "Circulation Policies" since "issuing" doesn't fit well with
current terminology conventions. The term "circulation" is broad enough to
encompass checkouts, fines, and holds.

 - Better define and delineate the sub-sections on the page:
   - Default checkout and hold policy
   - Checkout limit by patron category
   - Holds policy by item type

 - Repeat the current library name, when selected, for clarity: "Default
checkout and hold policy for Athens" rather than "Default checkout and hold
policy for this library"

 - Use the phrase "all libraries" when no library is selected. "Default
library" seems ambiguous. "All libraries" better defines how the rule will be
applied: to all libraries in the absence of a more specific rule.
---
 .../intranet-tmpl/prog/en/css/staff-global.css     |    5 +++
 .../prog/en/modules/admin/smart-rules.tmpl         |   28 ++++++++-----------
 2 files changed, 17 insertions(+), 16 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
index 13ac2c7..f786fc1 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
@@ -1883,3 +1883,8 @@ ul.budget_hierarchy li:last-child:after {
 ul.budget_hierarchy li:first-child:after {
     content: "";
 }
+.container {
+	border : 1px solid #EEE;
+	padding : 1em;
+	margin : 1em 0;
+}
\ No newline at end of file
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl
index 5e5e183..2533028 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tmpl
@@ -1,5 +1,5 @@
 <!-- TMPL_INCLUDE NAME="doc-head-open.inc" -->
-<title>Koha &rsaquo; Administration &rsaquo; Issuing Rules</title>
+<title>Koha &rsaquo; Administration &rsaquo; Circulation Policies</title>
 <!-- TMPL_INCLUDE NAME="doc-head-close.inc" -->
 
 <script type="text/javascript">
@@ -18,7 +18,7 @@ $(document).ready(function() {
 <!-- TMPL_INCLUDE NAME="header.inc" -->
 <!-- TMPL_INCLUDE NAME="cat-search.inc" -->
 
-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> &rsaquo; Issuing Rules</div>
+<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a> &rsaquo; Circulation Policies</div>
 
 <div id="doc3" class="yui-t1">
 
@@ -27,9 +27,9 @@ $(document).ready(function() {
     <div class="yui-b">
     <h1 class="parameters">
         <!-- TMPL_IF NAME="humanbranch" -->
-            Defining issuing rules for "<!-- TMPL_VAR NAME="humanbranch" -->"
+            Defining circulation policies for "<!-- TMPL_VAR NAME="humanbranch" -->"
         <!-- TMPL_ELSE -->
-            Defining default issuing rules
+            Defining default circulation policies
         <!-- /TMPL_IF -->
     </h1>
     <div class="help">
@@ -144,11 +144,9 @@ $(document).ready(function() {
             </table>
         </form>
     </div>
-    <div class="help">
-        <h4>Defaults for this library</h4>
+    <div id="defaults-for-this-library" class="container">
+    <h3>Default checkout and hold policy for <!-- TMPL_IF NAME="humanbranch" --><!-- TMPL_VAR NAME="humanbranch" --><!-- TMPL_ELSE -->all libraries<!-- /TMPL_IF --></h3>
         <p>You can set a default maximum number of checkouts and hold policy that will be used if none is defined below for a particular item type or category.</p>
-    </div>
-    <div>
         <form method="post" action="/cgi-bin/koha/admin/smart-rules.pl">
             <input type="hidden" name="op" value="set-branch-defaults" />
             <input type="hidden" name="branch" value="<!-- TMPL_VAR NAME="branch" -->"/>
@@ -197,15 +195,14 @@ $(document).ready(function() {
         </form>
     </div>
     <!-- TMPL_IF NAME="show_branch_cat_rule_form" -->
-    <div class="help">
+    <div id="holds-policy-by-patron-category" class="container">
+    <h3>Checkout limit by patron category for <!-- TMPL_IF NAME="humanbranch" --><!-- TMPL_VAR NAME="humanbranch" --><!-- TMPL_ELSE -->all libraries<!-- /TMPL_IF --></h3>
         <p>For this library, you can specify the maximum number of loans that
             a patron of a given category can make, regardless of the item type.
         </p>
         <p>If the total amount loanable for a given patron category is left blank,
            no limit applies, except possibly for a limit you define for a specific item type.
         </p>
-    </div>
-    <div>
         <form method="post" action="/cgi-bin/koha/admin/smart-rules.pl">
             <input type="hidden" name="op" value="add-branch-cat" />
             <input type="hidden" name="branch" value="<!-- TMPL_VAR NAME="branch" -->"/>
@@ -253,7 +250,8 @@ $(document).ready(function() {
         </form>
     </div>
     <!-- /TMPL_IF -->
-    <div class="help">
+    <div id="holds-policy-by-item-type" class="container">
+    <h3>Holds policy by item type for <!-- TMPL_IF NAME="humanbranch" --><!-- TMPL_VAR NAME="humanbranch" --><!-- TMPL_ELSE -->all libraries<!-- /TMPL_IF --></h3>
         <p>
             For this library, you can edit rules for given itemtypes, regardless
             of the patron's category.
@@ -271,11 +269,9 @@ $(document).ready(function() {
             Note that if the system preference
             <code>AllowHoldPolicyOverride</code> is enabled, these policies can
             be overridden by your circulation staff. Also, these policies are
-            based on the patron's home branch, <em>not</em> the branch that
-            the reserving staff member is from.
+            based on the patron's home library, <em>not</em> the library where the hold is being placed..
         </p>
-    </div>
-    <div>
+
         <form method="post" action="/cgi-bin/koha/admin/smart-rules.pl">
             <input type="hidden" name="op" value="add-branch-item" />
             <input type="hidden" name="branch" value="<!-- TMPL_VAR NAME="branch" -->"/>
-- 
1.7.0.4



More information about the Koha-patches mailing list