[Koha-patches] [PATCH] Ability to link to items belong to host records from a analytical record

[Chris Cormack]

* savitra sirohi (savitra.sirohi at osslabs.biz) wrote:
> Hi Chris, can you please go ahead and apply this one, I will update
> the copyright per Galen's suggestion in a subsequent patch this week.

Done, its at new/awaiting_qa/analytical_records
on git.koha-community.org/koha.git

Chris
> 
> Hi Galen, on moving the code to C4, will do. Thanks for the suggestions.
> 
> - Savitra
> 
> On Thu, Nov 11, 2010 at 7:07 PM, Galen Charlton <gmcharlt at gmail.com> wrote:
> > Hi,
> >
> > On Wed, Nov 10, 2010 at 5:19 PM, Chris Cormack <chrisc at catalyst.net.nz> wrote:
> >> * savitra.sirohi at osslabs.biz (savitra.sirohi at osslabs.biz) wrote:
> >>> From: Amit Gupta <amit.gupta at osslabs.biz>
> >>>
> >>> ---
> >>>  cataloguing/linkitem.pl                            |   98 ++++++++++++++++++++
> >>>  .../intranet-tmpl/prog/en/includes/cat-toolbar.inc |    1 +
> >>>  .../prog/en/modules/cataloguing/linkitem.tmpl      |   57 +++++++++++
> >>>  3 files changed, 156 insertions(+), 0 deletions(-)
> >>>  create mode 100755 cataloguing/linkitem.pl
> >>>  create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tmpl
> >>>
> >>> diff --git a/cataloguing/linkitem.pl b/cataloguing/linkitem.pl
> >>> new file mode 100755
> >>> index 0000000..bff001e
> >>> --- /dev/null
> >>> +++ b/cataloguing/linkitem.pl
> >>> @@ -0,0 +1,98 @@
> >>> +#!/usr/bin/perl
> >>> +
> >>> +# Move an item from a biblio to another
> >>> +#
> >>> +# Copyright 2009 BibLibre
> >>
> >> Can you please fix the copyright statement here, and resend
> >>
> >> (You might want to check the other patches too, if we want to get into
> >> debian we need correct copyright (or at least a lot more correct than we
> >> have now) statements
> >
> > linkitem.pl is clearly a copy-and-paste of moveitem.pl with a few changes, so
> >
> > "Copyright 2009 BibLibre
> > Copyright 2010 OSSLabs"
> >
> > (or something like that) is probably the correct copyright statement.
> >
> > Also, a note on the patch itself - it's not ideal to have the MARC21
> > 773 field be referenced directly in the script - that really should be
> > wrapped in a C4 routine so that it is easier to maintain (and for Zeno
> > to add the UNIMARC support).
> >
> > Regards,
> >
> > Galen
> > --
> > Galen Charlton
> > gmcharlt at gmail.com
> >

-- 
Chris Cormack
Catalyst IT Ltd.
+64 4 803 2238
PO Box 11-053, Manners St, Wellington 6142, New Zealand
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: </pipermail/koha-patches/attachments/20101115/ae62353c/attachment.pgp>