[Koha-patches] [bug 5204] Unimarc XSLT, from French to English. 2nd version. This is the second version of the patch. Discard the first. This patch will be signed-off by Frederic DEMIANS.

Galen Charlton gmcharlt at gmail.com
Mon Nov 15 17:10:38 CET 2010


Hi,

On Mon, Nov 15, 2010 at 10:13 AM,  <tajoli at cilea.it> wrote:
[a patch]

I've signed off on the patch -- it addresses the XML parsing problem I
was concerned about with the previous version and seems to do what it
claims.  However, for a substantive sign-off, I suggest that the RM
indeed wait for Frédéric or another UNIMARC user to test first as
suggested by Zeno.

Please note that I've tweaked the wording of the commit message:

* The bug number will no longer be stripped by git-am.  git-am strips
off all leading text in the subject line that is surrounded by square
brackets, so when you are commiting, you should not cite the bug
number like this:

[Bug 1234] Fix the foo module

Instead, do something like this:

Bug 1234: Fix the foo module

or

bug 1234 fix the foo module

or so on.

* I've removed the bit about this being the second revision of the
patch -- that isn't going to be relevant once this is pushed to
master.

Regards,

Galen
-- 
Galen Charlton
gmcharlt at gmail.com


More information about the Koha-patches mailing list