[Koha-patches] [PATCH] Bug 5408 - Refactor GetIssuingRule and GetLoanLength

[Clay Fouts]

What's the status of merging this development? Is anyone working on it? My
implementation of that particular function is more readable (and less DB
intensive in many cases), but your branch has the advantage in terms of
being more complete and fully separating out the issuing rules concerns into
their own module. What remains to be done?

Clay


On Mon, Nov 15, 2010 at 10:16 AM, LAURENT Henri-Damien <
henridamien.laurent at biblibre.com> wrote:

> Le 15/11/2010 17:45, Clay Fouts a écrit :
> > Well, that's a much larger project since AFAICT all the issuingrules
> > table mutations come from directly within smart-rules.pl
> > <http://smart-rules.pl>. So all that code needs to me moved into
> C4::Circ.
> >
> > As is, there's no actual freshness issue since the cache-enabled
> > functions are not used from within any script that also mutates the
> > data. That cache-reset function is there as a reminder to use it when
> > there's further normalization to the data layer.
> In order to adress that concern, we created a Perl Module
> C4::IssuingRules.pm
> Due to the time we did it (at least 6 month ago)... It is not using
> DBIx::Class but C4::SQLHelper.
> But it does what you wanted to do.
> And quite help improving the user interface...
> See the smart-rules page on BibLibre-memb-circ-update
> in wip/koha-biblibre.git in order to see the results of the development.
>
> Feel free to test and comment on that.
> If you donot want to create a test we can set one up as we did for other
> branches, just ask.
>
> --
> Henri-Damien LAURENT
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: </pipermail/koha-patches/attachments/20101116/7bff550e/attachment.htm>