[Koha-patches] [PATCH] bug 5066: log timestamp consistently in _session_log

Chris Cormack chrisc at catalyst.net.nz
Wed Nov 17 05:00:39 CET 2010


Can you please rebase this against master, and resend. It currently
doesnt apply

Chris

* Marcel de Rooy (M.de.Rooy at rijksmuseum.nl) wrote:
> From: Galen Charlton <gmcharlt at gmail.com>
> 
> Alternative to Marcel de Rooy's patch of 4 November.  The
> rest of C4/Auth.pm uses strftime("%c", localtime) to format
> the timestamp, and in general,
> strftime('%c', localtime) ne scalar(localtime).
> 
> Signed-off-by: Galen Charlton <gmcharlt at gmail.com>
> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
> ---
>  C4/Auth.pm |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/C4/Auth.pm b/C4/Auth.pm
> index c7477b1..7404f96 100644
> --- a/C4/Auth.pm
> +++ b/C4/Auth.pm
> @@ -717,7 +717,7 @@ sub checkauth {
>                     ( $return, $cardnumber ) = checkpw( $dbh, $userid, $password, $query );
>                 }
>                 if ($return) {
> -               _session_log(sprintf "%20s from %16s logged in  at %30s.\n", $userid,$ENV{'REMOTE_ADDR'},localtime);
> +               _session_log(sprintf "%20s from %16s logged in  at %30s.\n", $userid,$ENV{'REMOTE_ADDR'},(strftime '%c', localtime));
>                 if ( $flags = haspermission(  $userid, $flagsrequired ) ) {
>                                         $loggedin = 1;
>                 }
> --
> 1.6.0.6
> _______________________________________________
> Koha-patches mailing list
> Koha-patches at lists.koha-community.org
> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-patches
> website : http://www.koha-community.org/
> git : http://git.koha-community.org/
> bugs : http://bugs.koha-community.org/

-- 
Chris Cormack
Catalyst IT Ltd.
+64 4 803 2238
PO Box 11-053, Manners St, Wellington 6142, New Zealand
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: </pipermail/koha-patches/attachments/20101117/80c0bf13/attachment-0001.pgp>


More information about the Koha-patches mailing list