[Koha-patches] [PATCH] Fix for Bug 5265, error message on lists is misleading
Owen Leonard
oleonard at myacpl.org
Mon Oct 4 16:32:42 CEST 2010
The check to see if an item exists always evaluates as true.
Correcting this lets the script handle the error as it
was designed to.
---
C4/VirtualShelves/Page.pm | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/C4/VirtualShelves/Page.pm b/C4/VirtualShelves/Page.pm
index 73ca42d..9d15847 100644
--- a/C4/VirtualShelves/Page.pm
+++ b/C4/VirtualShelves/Page.pm
@@ -89,7 +89,8 @@ sub shelfpage ($$$$$) {
if ( $shelfnumber = $query->param('viewshelf') ) {
if ( ShelfPossibleAction( $loggedinuser, $shelfnumber, 'manage' ) ) {
if ( $barcode = $query->param('addbarcode') ) {
- if ( $item = GetItem( 0, $barcode ) ) {
+ $item = GetItem( 0, $barcode );
+ if (defined $item && $item->{'itemnumber'}){
$biblio = GetBiblioFromItemNumber( $item->{'itemnumber'} );
AddToShelf( $biblio->{'biblionumber'}, $shelfnumber )
or push @paramsloop, { duplicatebiblio => $barcode };
--
1.7.0.4
More information about the Koha-patches
mailing list