[Koha-patches] [PATCH] [SIGNED-OFF] Partial fix for Bug 4870, Damaged status does not prevent items from being selected for reserves

[Christophe Croullebois]

From: Owen Leonard <oleonard at myacpl.org>

This patch changes the holds queue build process in order to
require that items not be damaged in order to appear in the
holds queue report.

Revision adds a check for the AllowHoldsOnDamagedItems preference to
determine whether a damaged item should be included in the holds
queue report.

Signed-off-by: Christophe Croullebois <christophe.croullebois at biblibre.com>
---
 misc/cronjobs/holds/build_holds_queue.pl |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/misc/cronjobs/holds/build_holds_queue.pl b/misc/cronjobs/holds/build_holds_queue.pl
index b02ab60..f01153e 100755
--- a/misc/cronjobs/holds/build_holds_queue.pl
+++ b/misc/cronjobs/holds/build_holds_queue.pl
@@ -168,8 +168,9 @@ sub GetItemsAvailableToFillHoldRequestsForBib {
     $items_query .=   "WHERE items.notforloan = 0
                        AND holdingbranch IS NOT NULL
                        AND itemlost = 0
-                       AND wthdrawn = 0
-                       AND items.onloan IS NULL
+                       AND wthdrawn = 0";
+    $items_query .=   " AND damaged = 0 " unless C4::Context->preference('AllowHoldsOnDamagedItems');
+    $items_query .=   " AND items.onloan IS NULL
                        AND (itemtypes.notforloan IS NULL OR itemtypes.notforloan = 0)
                        AND itemnumber NOT IN (
                            SELECT itemnumber
-- 
1.7.0.4