[Koha-patches] [PATCH] [SIGNED-OFF] Fix for Bug 5950 - changing frameworks doesn't change anymore

fdurand frederic.durand at univ-lyon2.fr
Fri Apr 8 12:16:08 CEST 2011


From: Owen Leonard <oleonard at myacpl.org>

Selecting a framework from the dropdown menu has never (AFAICT)
auto-submitted the form to change the framework. This patch
reformats the form in order to make it clearer that this menu
 is part of the search function.

Signed-off-by: fdurand <frederic.durand at univ-lyon2.fr>
---
 .../prog/en/modules/admin/marctagstructure.tmpl    |   29 +++++++++-----------
 1 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tmpl
index 1e9fb34..032a6df 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tmpl
@@ -49,7 +49,7 @@ $(document).ready(function() {
 &rsaquo; <a href="/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode=<!-- TMPL_VAR NAME="frameworkcode" -->"><!-- TMPL_VAR NAME="frameworktext" --> (<!-- TMPL_VAR NAME="frameworkcode" -->)</a>
 &rsaquo; <!-- TMPL_VAR name="action" --> <!-- TMPL_VAR NAME="searchfield" -->
 <!-- TMPL_ELSIF name="else" -->
-&rsaquo; <a href="/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode=<!-- TMPL_VAR NAME="frameworkcode" -->"><!-- TMPL_VAR NAME="frameworktext" --> (<!-- TMPL_VAR NAME="frameworkcode" -->)</a>
+&rsaquo; <a href="/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode=<!-- TMPL_VAR NAME="frameworkcode" -->"><!-- TMPL_IF NAME="frameworkcode" --><!-- TMPL_VAR NAME="frameworktext" --> (<!-- TMPL_VAR NAME="frameworkcode" -->)<!-- TMPL_ELSE -->Default MARC framework<!-- /TMPL_IF --></a>
 <!-- TMPL_ELSIF name="delete_confirm" -->
 &rsaquo; <a href="/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode=<!-- TMPL_VAR NAME="frameworkcode" -->"><!-- TMPL_VAR NAME="frameworktext" --> (<!-- TMPL_VAR NAME="frameworkcode" -->)</a>
 &rsaquo; Confirm Deletion of Tag '<!-- TMPL_VAR name="searchfield" -->'
@@ -132,33 +132,30 @@ $(document).ready(function() {
 
 
 <!-- TMPL_IF NAME="else" -->
-
 <form name="f" action="<!-- TMPL_VAR NAME="script_name" -->" method="post">
-    <p><label for="frameworkcode">Framework</label>
+<fieldset style="padding:.5em;">
+        <label for="searchfield"><strong>Search for tag:</strong> </label>
+        <input type="text" name="searchfield" id="searchfield" size="4" value="<!-- TMPL_VAR NAME="searchfield" -->" />
+
+<label for="frameworkcode"><strong>In framework:</strong> </label>
         <select id="frameworkcode" name="frameworkcode">
             <option value="">Default</option>
             <!-- TMPL_LOOP NAME="frameworkloop" -->
-			<!-- TMPL_IF NAME="selected" -->
+            <!-- TMPL_IF NAME="selected" -->
                 <option value="<!-- TMPL_VAR NAME="value" -->" selected="selected"><!-- TMPL_VAR NAME="frameworktext" --></option>
-				<!-- TMPL_ELSE -->
+                <!-- TMPL_ELSE -->
                 <option value="<!-- TMPL_VAR NAME="value" -->"><!-- TMPL_VAR NAME="frameworktext" --></option>
-				<!-- /TMPL_IF -->
+                <!-- /TMPL_IF -->
             <!-- /TMPL_LOOP -->
         </select>
-    </p>
-    <p>
-        <label for="searchfield">Search for Tag</label>
-        <input type="text" name="searchfield" id="searchfield" value="<!-- TMPL_VAR NAME="searchfield" -->" />
-        <input type="submit" value="Search" />
-    </p>
-    <p>
-        <label for="select_display">Display only used Tags/Subfields</label>
+    <input type="submit" value="Search" />
+<p>        <label for="select_display">Display only used Tags/Subfields</label>
         <!-- TMPL_IF Name="select_display"-->
             <input type="checkbox" name="select_display" id="select_display" value="True" checked="checked"  onchange="this.form.submit();" />
         <!-- TMPL_ELSE -->
             <input type="checkbox" name="select_display" id="select_display" value="True" onchange="this.form.submit();" />
-        <!--/TMPL_IF -->
-    </p>
+        <!--/TMPL_IF --></p>
+</fieldset>
 </form>
 <span id="pagertable_marctagstructure" class="pager">
 	<form class="formpager">&nbsp;<strong>page(s)</strong>&nbsp;:
-- 
1.7.1



More information about the Koha-patches mailing list