[Koha-patches] [PATCH] [SIGNED-OFF] Bug 6667 Correct documentation of function

Marcel de Rooy M.de.Rooy at rijksmuseum.nl
Thu Aug 4 15:25:16 CEST 2011


From: Colin Campbell <colin.campbell at ptfs-europe.com>

Return list was documented as being in the reverse order
to how it is returned. Correct the perldoc description

also removed comments which did not help anyone trying
to make sense of this subroutine

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Just improving text comments. No code changes involved.
---
 C4/Members.pm |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/C4/Members.pm b/C4/Members.pm
index 2ce3030..00758b8 100644
--- a/C4/Members.pm
+++ b/C4/Members.pm
@@ -1191,12 +1191,10 @@ sub GetMemberAccountRecords {
 
 =head2 GetBorNotifyAcctRecord
 
-  ($count, $acctlines, $total) = &GetBorNotifyAcctRecord($params,$notifyid);
+  ($total, $acctlines, $count) = &GetBorNotifyAcctRecord($params,$notifyid);
 
 Looks up accounting data for the patron with the given borrowernumber per file number.
 
-(FIXME - I'm not at all sure what this is about.)
-
 C<&GetBorNotifyAcctRecord> returns a three-element array. C<$acctlines> is a
 reference-to-array, where each element is a reference-to-hash; the
 keys are the fields of the C<accountlines> table in the Koha database.
@@ -1218,7 +1216,6 @@ sub GetBorNotifyAcctRecord {
                     AND amountoutstanding != '0' 
                 ORDER BY notify_id,accounttype
                 ");
-#                    AND (accounttype='FU' OR accounttype='N' OR accounttype='M'OR accounttype='A'OR accounttype='F'OR accounttype='L' OR accounttype='IP' OR accounttype='CH' OR accounttype='RE' OR accounttype='RL')
 
     $sth->execute( $borrowernumber, $notifyid );
     my $total = 0;
-- 
1.6.0.6



More information about the Koha-patches mailing list