[Koha-patches] [PATCH] Bug 6679 : acqui/ now passes Perl::Critic tests

Chris Cormack chrisc at catalyst.net.nz
Mon Aug 8 11:05:21 CEST 2011


---
 acqui/neworderempty.pl |    3 ++-
 t/00-testcritic.t      |    2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/acqui/neworderempty.pl b/acqui/neworderempty.pl
index c7d6083..05968c6 100755
--- a/acqui/neworderempty.pl
+++ b/acqui/neworderempty.pl
@@ -330,7 +330,8 @@ if (C4::Context->preference('AcqCreateItem') eq 'ordering' && !$ordernumber) {
     $template->param(items => \@itemloop);
 }
 # Get the item types list, but only if item_level_itype is YES. Otherwise, it will be in the item, no need to display it in the biblio
-my @itemtypes = C4::ItemType->all unless C4::Context->preference('item-level_itypes');
+my @itemtypes;
+ at itemtypes = C4::ItemType->all unless C4::Context->preference('item-level_itypes');
 
 # fill template
 $template->param(
diff --git a/t/00-testcritic.t b/t/00-testcritic.t
index 65f2288..4a285b3 100755
--- a/t/00-testcritic.t
+++ b/t/00-testcritic.t
@@ -16,7 +16,7 @@ my @all_koha_dirs = qw( acqui admin authorities basket C4 catalogue cataloguing
 labels members misc offline_circ opac patroncards reports reserve reviews rotating_collections
 serials sms suggestion t tags test tools virtualshelves);
 
-my @dirs = qw( basket circ debian errors offline_circ reserve reviews rotating_collections
+my @dirs = qw( acqui basket circ debian errors offline_circ reserve reviews rotating_collections
 serials sms virtualshelves );
 
 if ( not $ENV{TEST_QA} ) {
-- 
1.7.4.1



More information about the Koha-patches mailing list