[Koha-patches] [PATCH] 6699 Add not-empty check for warnings from load_sql in Installer

Marcel de Rooy M.de.Rooy at rijksmuseum.nl
Wed Aug 10 15:36:07 CEST 2011


Eliminates fake warnings "Something is wrong on line 530".
---
 C4/Installer.pm |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/C4/Installer.pm b/C4/Installer.pm
index 80ef627..4831969 100644
--- a/C4/Installer.pm
+++ b/C4/Installer.pm
@@ -526,8 +526,10 @@ sub load_sql {
         # report the import a failure although it really succeded -fbcit
     }
 #   errors thrown while loading installer data should be logged
-    warn "C4::Installer::load_sql returned the following errors while attempting to load $filename:\n";
-    warn $error;
+    if($error) {
+      warn "C4::Installer::load_sql returned the following errors while attempting to load $filename:\n";
+      warn $error;
+    }
     return $error;
 }

--
1.6.0.6


More information about the Koha-patches mailing list