[Koha-patches] [PATCH] [Signed Off] Alternate fix for Bug 2534 - Viewing items table on item edit screen requires horizontal scrolling

Liz Rea lrea at nekls.org
Tue Aug 30 17:40:36 CEST 2011


From: Owen Leonard <oleonard at myacpl.org>

This patch doesn't eliminate horizontal scrolling, but simplifies
the situation:

- The left-hand sidebar has been moved below the table of items.
- The "overflow:scroll" style has been removed from the table of items.
  Having overflow set meant that it was often necessary to scroll twice
  to reach data in the table: once using the scrollbars on the table
  and again using the page's scrollbars.

The NEKLS catalogers also extend their thanks for this fix.

Signed-off-by: Liz Rea <lrea at nekls.org>
---
 koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css  |   13 ++++++++++++-
 .../intranet-tmpl/prog/en/css/staff-global.css     |    3 ---
 .../prog/en/modules/cataloguing/additem.tt         |   19 ++++++++++---------
 3 files changed, 22 insertions(+), 13 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css
index 26a8066..3cf2e88 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css
+++ b/koha-tmpl/intranet-tmpl/prog/en/css/addbiblio.css
@@ -133,4 +133,15 @@ a.tagnum {
 .linktools a:first-child { border-bottom: 1px solid #DDD; }
 .linktools a:hover { background-color: #FFC; }
 .subfield_controls { margin : 0 .5em; }
-.readonly { border-width : 1px; border-style: inset; padding-left : 15px; background: #EEE url(../../img/locked.png) center left no-repeat; width:29em; }
\ No newline at end of file
+.readonly { border-width : 1px; border-style: inset; padding-left : 15px; background: #EEE url(../../img/locked.png) center left no-repeat; width:29em; }
+
+#cataloguing_additem_itemlist {
+	margin-bottom : 1em;
+}
+.yui-gf div.first {
+	width : 19%;
+}
+
+.yui-gf .yui-u {
+	width: 79.2%;
+}
\ No newline at end of file
diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
index 36cef19..8b2b8f5 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
@@ -1896,9 +1896,6 @@ img.spinner {
     vertical-align: middle;
     padding-right: 0.3em;
 }
-#cataloguing_additem_itemlist div {
-	overflow : scroll;
-}
 ul.budget_hierarchy {
     margin-left: 0px;
     padding-left: 0px;
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
index 2bd5ab5..efdda6a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
@@ -178,12 +178,10 @@ function set_to_today(id, force) {
  &rsaquo; <a href="/cgi-bin/koha/cataloguing/additem.pl?biblionumber=[% biblionumber %]">Items</a>
 </div>
 
-<div id="doc3" class="yui-t2">
+<div id="doc3" class="yui-t7">
 
    <div id="bd">
 	<div id="yui-main">
-	<div class="yui-b">
-
 
 <h1>Items for [% title |html %] [% IF ( author ) %] by [% author %][% END %] (Record #[% biblionumber %])</h1>
 
@@ -218,7 +216,11 @@ function set_to_today(id, force) {
         </div>
     [% END %]
 </div>
-
+<div class="yui-gf">
+<div class="yui-u first">
+[% INCLUDE 'biblio-view-menu.inc' %]
+</div>
+<div class="yui-u">
 <div id="cataloguing_additem_newitem">
     <form method="post" action="/cgi-bin/koha/cataloguing/additem.pl" name="f">
     <input type="hidden" name="op" value="[% op %]" />
@@ -273,17 +275,16 @@ function set_to_today(id, force) {
     [% END %]</fieldset>
     
     <input type="hidden" name="borrowernumber" value="[% borrowernumber %]" />
-    <input type="hidden" name="stickyduedate"" value="[% stickyduedate %]" />
+    <input type="hidden" name="stickyduedate" value="[% stickyduedate %]" />
     <input type="hidden" name="barcode" value="[% barcode %]" />
     <input type="hidden" name="duedatespec" value="[% duedatespec %]" />
 
 
     </form>
 </div>
-</div>
-</div>
-<div class="yui-b">
-[% INCLUDE 'biblio-view-menu.inc' %]
+</div><!-- /yui-u -->
+</div><!-- /yui-gf -->
+
 </div>
 </div>
 [% INCLUDE 'intranet-bottom.inc' %]
-- 
1.7.2.5



More information about the Koha-patches mailing list