[Koha-patches] [PATCH] Bug 7247 - rebuild_zebra.pl -v should show all Zebra log output

[Dobrica Pavlinusic]

On Tue, Dec 20, 2011 at 04:54:17PM +0100, LAURENT Henri-Damien wrote:
> Le 20/12/2011 15:52, Dobrica Pavlinusic a écrit :
> > On Tue, Dec 20, 2011 at 02:06:24PM +0100, LAURENT Henri-Damien wrote:
> >>> -if ($verbose_logging) {
> >>> -    $zebraidx_log_opt = '';
> >>> +if ($verbose_logging >= 2) {
> >>> +    $zebraidx_log_opt = '-v none,fatal,warn,all';
> >>>  }
> >> mmm... in my opinion, all would be WAY too verbose.
> >> request,log are enough to debug the search query.
> >> my two cents.
> > 
> > all is very verbose, but does provide additional information about Zebra
> > progress (I must admit I'm leaning towards too much information as
> > opposed to too little).
> > 
> > Should I move all to verbose level 3 (-v -v -v) or just remove it all
> > together?
> > 
> I would leave that to -vvv
> When I looked at logs when all is set, I found it quite useless, but if
> you need that. I would say let's keep it for -vvv

I re-examined $zebraidx_log_opt handling with my changes, and default option
(without -v parameter or with single -v) is now "none,fatal,warn".

Only thing which is affected by -v -v is adding "all" to Zebra logs so I
think that moving it to -v -v -v isn't needed: it has same effect as -v -v
does now (and would leave -v -v doing nothing).

However, it does fixes behaviour with -v which used to reset Zebra log
options to '' and thus system defaults as opposed to leaving zebra log
flags at "none,fatal,warn".

Existing code does produce different logs without -v ("none,fatal,wran") and
with single -v (whatever is system default, which is usually just fatal),
but I think new behaviour is improvement in this regard.

Does this address your concernes with this patch?

-- 
Dobrica Pavlinusic               2share!2flame            dpavlin at rot13.org
Unix addict. Internet consultant.             http://www.rot13.org/~dpavlin