[Koha-patches] [PATCH] Bug 5589: Remove duplicated Exports in Suggestions.pm
Colin Campbell
colin.campbell at ptfs-europe.com
Fri Jan 7 12:44:03 CET 2011
Rather bizarrely Suggestions.pm was setting up @EXPORT, @ISA
and $VERSION twice. Have removed one invocation
---
C4/Suggestions.pm | 48 ++++++++++++------------------------------------
1 files changed, 12 insertions(+), 36 deletions(-)
diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm
index 5ea6c77..81ff731 100644
--- a/C4/Suggestions.pm
+++ b/C4/Suggestions.pm
@@ -29,46 +29,22 @@ use C4::SQLHelper qw(:all);
use C4::Debug;
use C4::Letters;
use List::MoreUtils qw<any>;
-use base 'Exporter'; # parent would be better there
+use C4::Dates qw(format_date_in_iso);
+use base qw(Exporter);
our $VERSION = 3.01;
our @EXPORT = qw<
- &ConnectSuggestionAndBiblio
- &CountSuggestion
- &DelSuggestion
- &GetSuggestion
- &GetSuggestionByStatus
- &GetSuggestionFromBiblionumber
- &ModStatus
- &ModSuggestion
- &NewSuggestion
- &SearchSuggestion
+ ConnectSuggestionAndBiblio
+ CountSuggestion
+ DelSuggestion
+ GetSuggestion
+ GetSuggestionByStatus
+ GetSuggestionFromBiblionumber
+ ModStatus
+ ModSuggestion
+ NewSuggestion
+ SearchSuggestion
>;
-use C4::Dates qw(format_date_in_iso);
-use vars qw($VERSION @ISA @EXPORT);
-
-BEGIN {
- # set the version for version checking
- $VERSION = 3.01;
- require Exporter;
- @ISA = qw(Exporter);
- @EXPORT = qw(
- &NewSuggestion
- &SearchSuggestion
- &GetSuggestion
- &GetSuggestionByStatus
- &DelSuggestion
- &CountSuggestion
- &ModSuggestion
- &ConnectSuggestionAndBiblio
- &GetSuggestionFromBiblionumber
- &ConnectSuggestionAndBiblio
- &DelSuggestion
- &GetSuggestion
- &GetSuggestionByStatus
- &GetSuggestionFromBiblionumber
- &ModStatus
- );
-}
+
=head1 NAME
--
1.7.3.4
More information about the Koha-patches
mailing list