[Koha-patches] [PATCH 1/4] ILS/Transaction Conforming to APIs

[paul.poulain at biblibre.com]

From: Henri-Damien LAURENT <henridamien.laurent at biblibre.com>

Checkout And Renew were not really using the full correct interface of AddIssue
Renew is using AddIssue where it could/should use AddRenewal
---
 C4/SIP/ILS/Transaction/Checkout.pm |    3 ++-
 C4/SIP/ILS/Transaction/Renew.pm    |    3 +++
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/C4/SIP/ILS/Transaction/Checkout.pm b/C4/SIP/ILS/Transaction/Checkout.pm
index 8a14877..7cd4ca9 100644
--- a/C4/SIP/ILS/Transaction/Checkout.pm
+++ b/C4/SIP/ILS/Transaction/Checkout.pm
@@ -60,6 +60,7 @@ sub do_checkout {
 	$debug and warn "do_checkout borrower: . " . Dumper $borrower;
 	my ($issuingimpossible,$needsconfirmation) = CanBookBeIssued( $borrower, $barcode );
 	my $noerror=1;
+	$debug and warn "do_checkout IssuingImpossible: . " , Dumper($issuingimpossible),"\n",Dumper($needsconfirmation);
     if (scalar keys %$issuingimpossible) {
         foreach (keys %$issuingimpossible) {
             # do something here so we pass these errors
@@ -116,7 +117,7 @@ sub do_checkout {
 	$debug and warn "do_checkout: calling AddIssue(\$borrower,$barcode, undef, 0)\n"
 		# . "w/ \$borrower: " . Dumper($borrower)
 		. "w/ C4::Context->userenv: " . Dumper(C4::Context->userenv);
-	my $c4due  = AddIssue($borrower, $barcode, undef, 0);
+	my $c4due  = AddIssue($borrower, $barcode, undef, 0,undef,1);
 	my $due  = $c4due->output('iso') || undef;
 	$debug and warn "Item due: $due";
 	$self->{'due'} = $due;
diff --git a/C4/SIP/ILS/Transaction/Renew.pm b/C4/SIP/ILS/Transaction/Renew.pm
index 73acaa3..57d6c9d 100644
--- a/C4/SIP/ILS/Transaction/Renew.pm
+++ b/C4/SIP/ILS/Transaction/Renew.pm
@@ -37,6 +37,9 @@ sub do_renew_for ($$) {
 	my $borrower = shift;
 	my ($renewokay,$renewerror) = CanBookBeRenewed($borrower->{borrowernumber},$self->{item}->{itemnumber});
 	if ($renewokay){
+        #Why not AddRenewal ????
+		#my $datedue = AddRenewal( $borrower, $self->{item}->id, undef, 0 );
+
 		my $datedue = AddIssue( $borrower, $self->{item}->id, undef, 0 );
 		$self->{due} = $datedue;
 		$self->renewal_ok(1);
-- 
1.7.1