[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5367: Batch Mod and Delete require superlibrarian permissions

[Nicole Engard]

From: Ian Walls <ian.walls at bywatersolutions.com>

This only occurs with IndependantBranches turned on; in an attempt to check that the items being
modified belonged to the user's branch, the code made a simultaneous comparison and assignment,
which is not permitted in all compilations of Perl.

Splitting the assignment of $itembranchcode and the check for its non-null value fixes the problem

Signed-off-by: Nicole Engard <nengard at bywatersolutions.com>
---
 tools/batchMod.pl |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/tools/batchMod.pl b/tools/batchMod.pl
index 921c4d6..d9a0b76 100755
--- a/tools/batchMod.pl
+++ b/tools/batchMod.pl
@@ -429,7 +429,8 @@ sub BuildItemsData{
 			my %this_row;
 			foreach my $field (grep {$_->tag() eq $itemtagfield} $itemmarc->fields()) {
 				# loop through each subfield
-				if (my $itembranchcode=$field->subfield($branchtagsubfield) && C4::Context->preference("IndependantBranches")) {
+				my $itembranchcode=$field->subfield($branchtagsubfield);
+				if ($itembranchcode && C4::Context->preference("IndependantBranches")) {
 						#verifying rights
 						my $userenv = C4::Context->userenv();
 						unless (($userenv->{'flags'} == 1) or (($userenv->{'branch'} eq $itembranchcode))){
-- 
1.5.6.5