[Koha-patches] [PATCH] Bug 6323 -- Error handling cleanup for moveitem.tt

Liz Rea lrea at nekls.org
Tue May 10 22:33:44 CEST 2011 

Apologies for the resend, I added in some things based on suggestions, so please I'd appreciate another sign off on this new version. :)

LR

On May 10, 2011, at 2:55 PM, Liz Rea wrote:

> Added button to retry attaching item, added default bib view handling, cosmetic changes to the error display (buttons now in error div).
> ---
> .../prog/en/modules/cataloguing/moveitem.tt        |  105 +++++++++++++++-----
> 1 files changed, 81 insertions(+), 24 deletions(-)
> 
> diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt
> index 4956f18..2c1afd7 100644
> --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt
> +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/moveitem.tt
> @@ -5,33 +5,90 @@
> <body>
> [% INCLUDE 'header.inc' %]
> [% INCLUDE 'cat-search.inc' %]
> -<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/cataloging/addbooks.pl">Cataloging</a>  &rsaquo; Attach an item to <i>[% bibliotitle |html %]</i></div>
> +<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/cataloging/addbooks.pl">Cataloging</a>  &rsaquo; Attach an item to <i>[% bibliotitle |html %][% IF ( itemsloo.subtitle ) %][% itemsloo.subtitle %][% END %]</i></div>
> <div id="doc" class="yui-t7">
> 
> [% IF ( error ) %]
>     <div class="dialog alert">
> -	[% IF ( errornonewitem ) %]ERROR: Unable to create the new item.[% END %]
> -	[% IF ( errornoitem ) %]ERROR: Unable to get the item.[% END %]
> -	[% IF ( errornoitemnumber ) %]ERROR: Unable to get the item number from this barcode.[% END %]
> -    </div>
> -    <form action="/cgi-bin/koha/catalogue/MARCdetail.pl" method="post">
> -	<input type="submit" value="OK" />
> -	<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
> -    </form>
> -[% ELSE %]
> -    [% IF ( success ) %]
> -	<div class="dialog message">The item has successfully been attached to [% INCLUDE 'biblio-default-view.inc' %]<i>[% bibliotitle |html %]</i></a>.[% IF ( BiblioDefaultViewmarc ) %]
> -	<form action="/cgi-bin/koha/catalogue/MARCdetail.pl" method="post">
> -[% ELSIF ( BiblioDefaultViewlabeled_marc ) %]
> -	<form action="/cgi-bin/koha/catalogue/labeledMARCdetail.pl" method="post">
> -[% ELSIF ( BiblioDefaultViewisbd ) %]
> -	<form action="/cgi-bin/koha/catalogue/ISBDdetail.pl" method="post">
> -[% ELSE %]
> -	<form action="/cgi-bin/koha/catalogue/detail.pl" method="post">
> -[% END %]
> -	    <input type="submit"  class="approve" value="OK" />
> -	    <input type="hidden" name="biblionumber" value="[% biblionumber %]" />
> -	</form></div>
> +		[% IF ( errornonewitem ) %]ERROR: Unable to create the new item.<p>
> +
> +			[% IF ( BiblioDefaultViewmarc ) %]
> +				<form action="/cgi-bin/koha/catalogue/MARCdetail.pl" method="post">
> +			[% ELSIF ( BiblioDefaultViewlabeled_marc ) %]
> +				<form action="/cgi-bin/koha/catalogue/labeledMARCdetail.pl" method="post">
> +			[% ELSIF ( BiblioDefaultViewisbd ) %]
> +				<form action="/cgi-bin/koha/catalogue/ISBDdetail.pl" method="post">
> +			[% ELSE %]
> +				<form action="/cgi-bin/koha/catalogue/detail.pl" method="post">
> +			[% END %]
> +				<input type="submit"  value="OK" />
> +				<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
> +			</form>
> +				<form method="link" action="/cgi-bin/koha/cataloguing/moveitem.pl?biblionumber=[% biblionumber %]"/>
> +				<input type="submit" class="new" value="Attach Item"/>
> +				<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
> +			</form>
> +		</div>
> +		[% END %]
> +
> +		[% IF ( errornoitem ) %]ERROR: Unable to get the item.<p>
> +
> +			[% IF ( BiblioDefaultViewmarc ) %]
> +				<form action="/cgi-bin/koha/catalogue/MARCdetail.pl" method="post">
> +			[% ELSIF ( BiblioDefaultViewlabeled_marc ) %]
> +				<form action="/cgi-bin/koha/catalogue/labeledMARCdetail.pl" method="post">
> +			[% ELSIF ( BiblioDefaultViewisbd ) %]
> +				<form action="/cgi-bin/koha/catalogue/ISBDdetail.pl" method="post">
> +			[% ELSE %]
> +				<form action="/cgi-bin/koha/catalogue/detail.pl" method="post">
> +			[% END %]
> +				<input type="submit" value="OK" />
> +			    <input type="hidden" name="biblionumber" value="[% biblionumber %]" />
> +			</form>
> +				<form method="link" action="/cgi-bin/koha/cataloguing/moveitem.pl?biblionumber=[% biblionumber %]"/>
> +				<input type="submit" class="new" value="Attach Item"/>
> +				<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
> +			</form>
> +		</div>
> +		[% END %]
> +
> +		[% IF ( errornoitemnumber ) %]ERROR: Unable to get the item number from this barcode.<p>
> +
> +			[% IF ( BiblioDefaultViewmarc ) %]
> +				<form action="/cgi-bin/koha/catalogue/MARCdetail.pl" method="post">
> +			[% ELSIF ( BiblioDefaultViewlabeled_marc ) %]
> +				<form action="/cgi-bin/koha/catalogue/labeledMARCdetail.pl" method="post">
> +			[% ELSIF ( BiblioDefaultViewisbd ) %]
> +				<form action="/cgi-bin/koha/catalogue/ISBDdetail.pl" method="post">
> +			[% ELSE %]
> +				<form action="/cgi-bin/koha/catalogue/detail.pl" method="post">
> +			[% END %]
> +				<input type="submit" value="OK" />
> +				<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
> +			</form>
> +				<form method="link" action="/cgi-bin/koha/cataloguing/moveitem.pl?biblionumber=[% biblionumber %]"/>
> +				<input type="submit" class="new" value="Attach Item"/>
> +				<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
> +			</form>
> +		</div>
> +		[% END %]
> +
> +	[% ELSE %]
> +	    [% IF ( success ) %]
> +			<div class="dialog message">The item has successfully been attached to [% INCLUDE 'biblio-default-view.inc' %]<i>[% bibliotitle |html %]</i></a>.
> +		[% IF ( BiblioDefaultViewmarc ) %]
> +			<form action="/cgi-bin/koha/catalogue/MARCdetail.pl" method="post">
> +		[% ELSIF ( BiblioDefaultViewlabeled_marc ) %]
> +			<form action="/cgi-bin/koha/catalogue/labeledMARCdetail.pl" method="post">
> +		[% ELSIF ( BiblioDefaultViewisbd ) %]
> +			<form action="/cgi-bin/koha/catalogue/ISBDdetail.pl" method="post">
> +		[% ELSE %]
> +			<form action="/cgi-bin/koha/catalogue/detail.pl" method="post">
> +		[% END %]
> +		    <input type="submit"  class="approve" value="OK" />
> +			<input type="hidden" name="biblionumber" value="[% biblionumber %]" />
> +		</form>
> +	</div>
> 
>     [% ELSE %]
> 	[% IF ( missingparameter ) %]
> @@ -39,7 +96,7 @@
> 	    [% IF ( missingbiblionumber ) %]
> 	    <fieldset id="biblionumber_fieldset">
> 		<label for="biblionumber">Select the biblionumber to attach the item to</label>
> -		    <div class="hint">Enter biblionumber:</div>
> +			<div class="hint">Enter biblionumber:</div>
> 		    <input type="text" name="biblionumber" id="biblionumber" class="focus" size="14" />
> 		    <fieldset class="action"><input type="submit" value="Submit" /></fieldset>
> 	    </fieldset>
> -- 
> 1.5.6.5
> 

Liz Rea
lrea at nekls.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: email_signature.jpeg
Type: image/jpeg
Size: 4862 bytes
Desc: not available
URL: </pipermail/koha-patches/attachments/20110510/b2a2996a/attachment-0001.jpeg>
-------------- next part --------------

More information about the Koha-patches mailing list