[Koha-patches] [PATCH 2/2] [SIGNED-OFF] bug 6409: fix pagination of SQL report output when parameters are used

Nicole C. Engard nengard at bywatersolutions.com
Tue May 24 21:25:41 CEST 2011


From: Galen Charlton <gmcharlt at gmail.com>

Fixes bug where paging through output of an SQL report that includes
one or more parameters fails by asking you for the parameter values
and again and sending you back to the first page of results.

Signed-off-by: Galen Charlton <gmcharlt at gmail.com>
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
---
 reports/guided_reports.pl |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl
index 600ac29..582c0dc 100755
--- a/reports/guided_reports.pl
+++ b/reports/guided_reports.pl
@@ -21,6 +21,7 @@ use strict;
 #use warnings; FIXME - Bug 2505
 use CGI;
 use Text::CSV;
+use URI::Escape;
 use C4::Reports::Guided;
 use C4::Auth qw/:DEFAULT get_session/;
 use C4::Output;
@@ -521,6 +522,9 @@ elsif ($phase eq 'Run this report'){
 
         my $totpages = int($total/$limit) + (($total % $limit) > 0 ? 1 : 0);
         my $url = "/cgi-bin/koha/reports/guided_reports.pl?reports=$report&amp;phase=Run%20this%20report";
+        if (@sql_params) {
+            $url = join('&amp;sql_params=', $url, map { URI::Escape::uri_escape($_) } @sql_params);
+        }
         $template->param(
             'results' => \@rows,
             'sql'     => $sql,
-- 
1.7.2.3



More information about the Koha-patches mailing list