[Koha-patches] [PATCH] [SIGNED-OFF] Bug 5579: further fancifying remove_items_from_biblioitems.pl

Liz Rea lrea at nekls.org
Thu May 26 03:25:42 CEST 2011


From: ruth at bywatersolutions.com <ruth at bywatersolutions.com>

This patch adds a progress indicator to remove_items_from_biblioitems.pl, with
the user option of silencing it with --silent.

Signed-off-by: Liz Rea <lrea at nekls.org>
---
 misc/maintenance/remove_items_from_biblioitems.pl |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/misc/maintenance/remove_items_from_biblioitems.pl b/misc/maintenance/remove_items_from_biblioitems.pl
index 0778b29..9f30db0 100755
--- a/misc/maintenance/remove_items_from_biblioitems.pl
+++ b/misc/maintenance/remove_items_from_biblioitems.pl
@@ -20,15 +20,17 @@
 
 use strict;
 use warnings;
+$|=1;
 
 use C4::Context;
 use C4::Biblio;
 use Getopt::Long;
 
-my ($wherestring, $run, $want_help);
+my ($wherestring, $run, $silent, $want_help);
 my $result = GetOptions(
     'where:s'      => \$wherestring,
     '--run'        => \$run,
+    '--silent'     => \$silent,
     'help|h'       => \$want_help,
 );
 
@@ -38,11 +40,15 @@ if ( not $result or not $run or $want_help ) {
 }
 
 my $dbh = C4::Context->dbh;
+my $count = 0;
 my $querysth =  qq{SELECT biblionumber from biblioitems };
 $querysth    .= " WHERE $wherestring " if ($wherestring);
 my $query = $dbh->prepare($querysth);
 $query->execute;
 while (my $biblionumber = $query->fetchrow){
+    $count++;
+    print "." unless $silent;
+    print "\r$count" unless ($silent or ($count % 100)); 
     my $record = GetMarcBiblio($biblionumber);
     
     if ($record) {
@@ -53,6 +59,8 @@ while (my $biblionumber = $query->fetchrow){
     }
 }
 
+print "\n\n$count records processed.\n" unless $silent;
+
 sub print_usage {
     print <<_USAGE_;
 $0: removes items from selected biblios
@@ -66,6 +74,7 @@ should be run using rebuild_zebra.pl -b -r.
 Parameters:
     -where                  use this to limit modifications to selected biblios
     --run                   perform the update
+    --silent                run silently
     --help or -h            show this message
 _USAGE_
 }
-- 
1.7.2.5



More information about the Koha-patches mailing list