[Koha-patches] [PATCH] [SIGNED-OFF] Bug 7138: Can't print basket group order pdf
Marcel de Rooy
M.de.Rooy at rijksmuseum.nl
Thu Nov 3 10:01:11 CET 2011
From: Katrin Fischer <Katrin.Fischer.83 at web.de>
PDF print of basket groups is broken.
To test:
1) Make sure OrderPdfFormat is set to pdfformat::layout2pages or pdfformat::layout3pages
2) Create a basket with orders
3) Close the basket and create a basket group checking the checkbox
4) Print the basket group as PDF
Before patch the file is broken and when opened in an editor contains an error message.
After the patch the PDF should be generated correctly again.
Thx to Chris for helping me to fix the problem.
Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Combined require and import into use. Added a warn statement.
---
acqui/basketgroup.pl | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl
index fbcad0f..46d49d9 100755
--- a/acqui/basketgroup.pl
+++ b/acqui/basketgroup.pl
@@ -186,12 +186,8 @@ sub printbasketgrouppdf{
my $pdfformat = C4::Context->preference("OrderPdfFormat");
if ($pdfformat eq 'pdfformat::layout3pages' || $pdfformat eq 'pdfformat::layout2pages'){
- eval {
- require $pdfformat;
- import $pdfformat;
- };
- if ($@){
- }
+ eval "use $pdfformat";
+ warn "Error while loading pdfformat module: $@" if $@;
}
else {
print $input->header;
--
1.6.0.6
More information about the Koha-patches
mailing list