[Koha-patches] [PATCH] Bug 7254 Show pending orders from baskets with closedate > 180 days
Marcel de Rooy
M.de.Rooy at rijksmuseum.nl
Wed Nov 23 13:54:17 CET 2011
Current code for selecting pending orders does not select orders from baskets
with a closedate > 180 days.
The code in Acquisition.pm already includes a FIXME for that.
IMHO this part of the where clause should just be removed; an order is pending
until it is filled. If you do not want to fill it, delete it.
---
C4/Acquisition.pm | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm
index a0dda42..7127f24 100644
--- a/C4/Acquisition.pm
+++ b/C4/Acquisition.pm
@@ -720,10 +720,7 @@ sub GetPendingOrders {
LEFT JOIN biblioitems ON biblioitems.biblionumber=biblio.biblionumber
WHERE booksellerid=?
AND (quantity > quantityreceived OR quantityreceived is NULL)
- AND datecancellationprinted IS NULL
- AND (to_days(now())-to_days(closedate) < 180 OR closedate IS NULL)
- ";
- ## FIXME Why 180 days ???
+ AND datecancellationprinted IS NULL";
my @query_params = ( $supplierid );
my $userenv = C4::Context->userenv;
if ( C4::Context->preference("IndependantBranches") ) {
--
1.6.0.6
More information about the Koha-patches
mailing list