[Koha-patches] [PATCH] Bug 6915 - [SIGNED-OFF] reduce module name truncation problem in koha_perl_deps.pl

Magnus Enger magnus at enger.priv.no
Thu Oct 6 16:08:56 CEST 2011


From: Greg Barniskis <gbarniskis at gmail.com>

Widen module name allowance in the format statement, adjust other
columns to be generous but not-so-much as before, modify report
header and footer print statements to align and clarify. Very very
long module names or version numbers are still subject to possible
truncation.

Signed-off-by: Magnus Enger <magnus at enger.priv.no>

Sign off comment: With this patch module names are not truncated, which is an
improvement. Lines are still too long to fit an 80 column display, and so they
wrap around, but tht is a minor annoyance compared to the truncated names.
---
 koha_perl_deps.pl |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/koha_perl_deps.pl b/koha_perl_deps.pl
index 934dea5..c5b614e 100755
--- a/koha_perl_deps.pl
+++ b/koha_perl_deps.pl
@@ -41,8 +41,9 @@ push @pm, 'current_pm' if $installed || $all;
 
 print color 'bold white' if $color;
 print"
-Module Name                                 Current Version                       Required Version         Module Required
---------------------------------------------------------------------------------------------------------------------------
+                                              Installed         Required          Module is
+Module Name                                   Version           Version            Required
+--------------------------------------------------------------------------------------------
 ";
 
 my $count = 0;
@@ -60,8 +61,8 @@ foreach my $type (@pm) {
             my $current_version = ($color ? $_->{$pm}->{'cur_ver'} :
                                    $type eq 'missing_pm' || $type eq 'upgrade_pm' ? $_->{$pm}->{'cur_ver'}." *" : $_->{$pm}->{'cur_ver'});
 format =
-@<<<<<<<<<<<<<<<<<<<<<<<<<                  @<<<<<<<<<<                           @<<<<<<<<<<              @<<<<<
-$pm,                                        $current_version,                     $_->{$pm}->{'min_ver'},  $required
+@<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<< @<<<<<<<<<<<<<<<<       @<<<<<
+$pm,                                          $current_version, $_->{$pm}->{'min_ver'},  $required
 .
 write;
         }
@@ -69,8 +70,8 @@ write;
 }
 print color 'bold white' if $color;
 my $footer = "
---------------------------------------------------------------------------------------------------------------------------
-Total modules reported: $count                                                     ";
+--------------------------------------------------------------------------------------------
+Total modules reported: $count                      ";
 
 if ($color) {
     $footer .= "\n\n";
-- 
1.7.4.1



More information about the Koha-patches mailing list