[Koha-patches] [PATCH] [SIGNED-OFF] Bug 7061: unnecessary global variables declared in C4::SQLHelper
Nicole C. Engard
nengard at bywatersolutions.com
Wed Oct 19 21:54:09 CEST 2011
From: Ian Walls <ian.walls at bywatersolutions.com>
Removes $tablename and $hash from global scope of C4/SQLHelper.pm. They are never used;
all instances of $table are locally scoped to the subroutines, and $hash is never used.
This may help with persistance; if not, it's at least a bit of trivial cleanup.
To test:
1. Search for a patron
2. Create a Contract in Acquisitions
3. Modify that Contract
4. Delete that Contract
All instances should return error free. This checks the subroutines of SQLHelper
Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com>
---
C4/SQLHelper.pm | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/C4/SQLHelper.pm b/C4/SQLHelper.pm
index 720dc99..e5ca94e 100644
--- a/C4/SQLHelper.pm
+++ b/C4/SQLHelper.pm
@@ -43,9 +43,6 @@ BEGIN {
);
}
-my $tablename;
-my $hash;
-
=head1 NAME
C4::SQLHelper - Perl Module containing convenience functions for SQL Handling
--
1.7.2.3
More information about the Koha-patches
mailing list