[Koha-patches] [PATCH] Bug 7084 - Adding results_summary class to New Tag to correct display inconsistency

Liz Rea lrea at nekls.org
Mon Oct 24 20:51:38 CEST 2011


To test:
Verify that New Tag text is the same size as all of the other surrounding text.
Verify that it is consistent with results that have tags.

See screenshot for what it looked like before: http://screencast.com/t/hnt15kpS7SH9
Notice that the Add button and New tag text were slightly larger than the similar constructions for results with existing tags. This patch should fix that.
---
 .../opac-tmpl/prog/en/modules/opac-results.tt      |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
index b7fbcb3..392f47b 100755
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
@@ -478,10 +478,11 @@ $(document).ready(function(){
 
 				[% END %]
 				[% IF ( LibraryThingForLibrariesID ) %]<div class="ltfl_reviews"></div>[% END %]
+				<div class="results_summary">
+
 				[% IF ( opacuserlogin ) %][% IF ( TagsEnabled ) %]
                                 [% IF ( TagsShowOnList ) %]
                                 [% IF ( SEARCH_RESULT.TagLoop.size ) %]
-                                    <div class="results_summary">
                                         <span class="label">Tags:</span>
                                         <ul style="display: inline; list-style: none;">[% FOREACH TagLoo IN SEARCH_RESULT.TagLoop %]<li style="display: inline; list-style: none;"><a href="/cgi-bin/koha/opac-search.pl?tag=[% TagLoo.term |url %]&amp;q=[% TagLoo.term |url %]">[% TagLoo.term %]</a> <span class="weight">([% TagLoo.weight_total %])</span></li>
                                             [% END %]
@@ -490,13 +491,14 @@ $(document).ready(function(){
                                 [% IF ( TagsInputOnList ) %]
                                     [% IF ( loggedinusername ) %]
                                     <form name="tagform[% SEARCH_RESULT.biblionumber %]" method="post" action="/cgi-bin/koha/opac-tags.pl">
-                                        <label for="newtag[% SEARCH_RESULT.biblionumber %]">New tag:</label>
+					<span class="label">New tag:</span>
                                         <input name="newtag[% SEARCH_RESULT.biblionumber %]" id="newtag[% SEARCH_RESULT.biblionumber %]" maxlength="100" />
                                         <input name="tagbutton" class="tagbutton" title="[% SEARCH_RESULT.biblionumber %]" type="submit" value="Add" />
                                     </form>
                                     <span id="newtag[% SEARCH_RESULT.biblionumber %]_status" class="tagstatus" style="display:none;">
                                         Tag status here.
                                     </span>
+				</div>
                                        [% ELSIF ( loop.first ) %]<span class="tagstatus" id="login4tags">Log in to add tags.</span>
                                     [% END %]
                                 [% END %]
-- 
1.7.2.5



More information about the Koha-patches mailing list