[Koha-patches] [PATCH] Bug 7461 - Cart offering to remove items when closing
Owen Leonard
oleonard at myacpl.org
Tue Jan 24 15:15:27 CET 2012
The "hide window" button in the cart called a quit() function
which deletes any checked items. My understanding of the "hide
window" button is that it should *only* hide the window, not
perform any other operations. I'm removing the calls to the
quit() function in both the OPAC and staff client and adding
a CSS class, "close," which is already tied via jQuery to
the window.close() function.
To test in both OPAC and staff client: Add items to the cart.
Try clicking the "hide window" button with items selected and
without. In both cases the window should close without affecting
the contents of the cart.
---
.../intranet-tmpl/prog/en/modules/basket/basket.tt | 2 +-
koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt
index 0896075..4239b4f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt
@@ -108,7 +108,7 @@ function placeHold () {
</li>
<li>
<span id="hide" class="yui-button yui-link-button"><span class="first-child">
- <a class="hide" href="basket.pl" onclick="quit(); return false;">Hide Window</a>
+ <a class="hide close" href="basket.pl">Hide Window</a>
</span></span>
</li>
</ul>
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt
index 62be158..a229521 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt
@@ -128,7 +128,7 @@ function tagAdded() {
<li><a class="download" href="opac-basket.pl" onclick="downloadBasket(); return false;">Download</a></li>
<li><a class="print" href="opac-basket.pl" onclick="printBasket(); return false;">Print</a></li>
<li><a class="empty" href="opac-basket.pl" onclick="delBasket(); return false;">Empty and Close</a></li>
- <li><a class="hide" href="opac-basket.pl" onclick="quit(); return false;">Hide Window</a></li>
+ <li><a class="hide close" href="opac-basket.pl">Hide Window</a></li>
</ul>
</div>
[% END %]
--
1.7.3
More information about the Koha-patches
mailing list