[Koha-patches] [PATCH] Bug 8178 - circ/circulation.pl under plack duplicates checkout rows
Dobrica Pavlinusic
dpavlin at rot13.org
Fri Jun 1 17:45:40 CEST 2012
Bug 7851 introduced our scoping for vairables, unfortunatly it has
side-effect that checkout rows accumulate on page reloads instead
of being initialized to empty array (which this patch fixes)
This also fixes %renew_failed initialization on each request.
Test scenario:
1. start intranet under plack
2. open /cgi-bin/koha/circ/circulation.pl and reload page few time
confirming that rows gets duplicated
3. apply patch and reload page to verify that it works
---
circ/circulation.pl | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/circ/circulation.pl b/circ/circulation.pl
index c89abff..858bfe5 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -94,7 +94,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user (
my $branches = GetBranches();
my @failedrenews = $query->param('failedrenew'); # expected to be itemnumbers
-our %renew_failed;
+our %renew_failed = {};
for (@failedrenews) { $renew_failed{$_} = 1; }
my $findborrower = $query->param('findborrower');
@@ -417,10 +417,10 @@ if ($borrowernumber) {
# make the issued books table.
my $todaysissues = '';
my $previssues = '';
-our @todaysissues;
-our @previousissues;
-our @relissues;
-our @relprevissues;
+our @todaysissues = ();
+our @previousissues = ();
+our @relissues = ();
+our @relprevissues = ();
my $displayrelissues;
our $totalprice = 0;
--
1.7.2.5
More information about the Koha-patches
mailing list