[Koha-patches] [PATCH] Bug 7952 - followup to fix t/Creators.t

Dobrica Pavlinusic dpavlin at rot13.org
Thu Jun 14 14:02:10 CEST 2012


Since we are now using temporary file, we are creating test.pdf
at end of test and checking if it exists and have non-zero size.
---
 t/Creators.t |   12 +++++++++---
 1 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/t/Creators.t b/t/Creators.t
index 720aa2c..85701c2 100755
--- a/t/Creators.t
+++ b/t/Creators.t
@@ -6,16 +6,16 @@
 use strict;
 use warnings;
 
-use Test::More tests => 15;
+use Test::More tests => 16;
 
 BEGIN {
         use_ok('C4::Creators');
         use_ok('C4::Creators::PDF');
 }
 
-my $pdf_creator = C4::Creators::PDF->new('test.pdf' => '', InitVars => 0);
+my $pdf_creator = C4::Creators::PDF->new(InitVars => 0);
 ok($pdf_creator, "testing new() works");
-if (-e 'test.pdf') {
+if (-e $pdf_creator->{filename}) {
   pass('testing pdf file created');
 }
 else {
@@ -40,6 +40,12 @@ is($pdf_creator->StrWidth("test", "H", 12), '19.344', "testing StrWidth() return
 is($result[0], '10', "testing Text() writes from a given x-value");
 is($result[1], '29.344', "testing Text() writes to the correct x-value");
 
+open(my $fh, '>', 'test.pdf');
+select $fh;
+
 ok($pdf_creator->End(), "testing End() works");
 
+close($fh);
+ok( -s 'test.pdf', 'test.pdf created' );
+
 unlink 'test.pdf';
-- 
1.7.2.5



More information about the Koha-patches mailing list