[Koha-patches] [PATCH] Bug 6939 DefaultClassificationSource should be default in 942

Colin Campbell colin.campbell at ptfs-europe.com
Mon Jun 18 12:33:47 CEST 2012


A logic bug in the original code adding DefaultClassificationSource
caused the default not to be used (the last used value was used instead)
The bug was fixed in additem by bug 2398 but addbiblio's use
of the code was not fixed.
---
 cataloguing/addbiblio.pl | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
index d5778a4..d9edf7a 100755
--- a/cataloguing/addbiblio.pl
+++ b/cataloguing/addbiblio.pl
@@ -215,10 +215,8 @@ sub build_authorized_values_list {
                         ($class_source eq $default_source);
             push @authorised_values, $class_source;
             $authorised_lib{$class_source} = $class_sources->{$class_source}->{'description'};
-            $value = $class_source unless ($value);
-            $value = $default_source unless ($value);
         }
-        #---- "true" authorised value
+        $value = $default_source unless $value;
     }
     else {
         $authorised_values_sth->execute(
-- 
1.7.11



More information about the Koha-patches mailing list