[Koha-patches] [PATCH 1/1] Bug 5180: FIX autocomplete on overdues report

Jonathan Druart jonathan.druart at biblibre.com
Wed Mar 14 14:40:05 CET 2012


- Switch off the CircAutocompl syspref
- Set a (one or more) patron attr type searchable
- go on the overdues page
Firebug crash and a layout problem appears on the left.

Firebug error is "YAHOO.widget.DS_XHR is not a constructor"

retry with this patch.
---
 .../intranet-tmpl/prog/en/modules/circ/overdue.tt  |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt
index e196399..4310a4f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt
@@ -24,7 +24,9 @@
 
 			var attrcode = $("script", clone).attr("x-code");
 			var newsuffix = parts[1] + appendid;
-			create_auto_completion_responder(newsuffix,attrcode);
+            [% IF ( CircAutocompl ) %]
+                create_auto_completion_responder(newsuffix,attrcode);
+            [% END %]
 		}
 
         parent.parentNode.insertBefore(clone, parent.nextSibling);
@@ -33,6 +35,7 @@
         var parent = node.parentNode;
         parent.parentNode.removeChild(parent);
     }
+    [% IF ( CircAutocompl ) %]
 	function create_auto_completion_responder(uniqueid,attrcode) {
 		YAHOO.util.Event.onContentReady("pattrodue-getready-"+uniqueid, function() {
 			new function() {
@@ -64,6 +67,7 @@
 			}
 		});
 	}
+    [% END %]
 //]]>
 </script>
 <style type="text/css">
@@ -190,8 +194,8 @@
 		<!-- domid cgivalue ismany isclone ordinal code description repeatable authorised_value_category -->
 		<li>
 			<label>[% patron_attr_filter_loo.description %]:</label>
-			[% IF ( patron_attr_filter_loo.authorised_value_category ) %]
-				<script type="text/JavaScript" language="JavaScript" x-code="[% patron_attr_filter_loo.code |html %]">create_auto_completion_responder([% patron_attr_filter_loo.domid %],"[% patron_attr_filter_loo.code |html %]");</script>
+            [% IF ( patron_attr_filter_loo.authorised_value_category AND CircAutocompl) %]
+                <script type="text/JavaScript" language="JavaScript" x-code="[% patron_attr_filter_loo.code |html %]">create_auto_completion_responder([% patron_attr_filter_loo.domid %],"[% patron_attr_filter_loo.code |html %]");</script>
 				<span id="pattrodue-getready-[% patron_attr_filter_loo.domid %]">
 						<div class="pattrodue-autocomplete">
 							<input autocomplete="off" id="pattrodue-input-[% patron_attr_filter_loo.domid %]" name="patron_attr_filter_[% patron_attr_filter_loo.code |html %]" value="[% patron_attr_filter_loo.cgivalue |html %]"  class="pattrodue-input" type="text" />
-- 
1.7.7.3



More information about the Koha-patches mailing list