[Koha-patches] [PATCH] Bug 8899 - Remove unused CSS declarations from staff client CSS

Owen Leonard oleonard at myacpl.org
Fri Oct 12 17:33:01 CEST 2012


Using an add-on for Firefox called CSS Usage I found some
instances of CSS in staff-global.css which are unused. Unused
selectors were confirmed by a search of the code.

Testers can't exactly check the whole staff client for things
which look off, but can confirm by their own search that
the removed CSS has no corresponding markup.
---
 .../intranet-tmpl/prog/en/css/staff-global.css     |  132 +-------------------
 1 file changed, 5 insertions(+), 127 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
index 71c3d3f..4e4e82a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
+++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
@@ -36,8 +36,6 @@ a.yuimenuitemlabel {
         color: #000000;
 }
 
-
-a.overdue,
 .overdue,
 .debit {
 	color : #cc0000;
@@ -128,22 +126,6 @@ em strong {
     font-style : italic;
 }
 
-#navigation {
-	border-right : 1px solid #BCBCBC;
-}
-
-#navigation li {
-	font-weight : bold;
-}
-
-#navigation li li {
-	font-weight : normal;
-}
-
-#navigation input {
-	font-size : 85%;
-}
-
 #navmenulist li {
 	padding : .2em 0;
 	list-style-image : url("../../img/arrow-bullet.gif");
@@ -227,39 +209,6 @@ ol li {
 .clearfix {display: block;}
 /* End hide from IE-mac */
 
-#sitetitle {
-/*	background-image : url("../../img/koha-logo-black.png");
-	background-position : 5px 2px;
-	background-repeat : no-repeat;
-	float : left;
-	height : 54px;
-	padding-left : 50px;*/
-	border-bottom : 1px solid #E8E8E8;
-}
-
-#sitetitle h1 {
-	display : inline;
-	line-height : 54px;
-}
-
-#sitetitle h1 a {
-	text-decoration : none;
-}
-
-#submenu {
-	margin : 0 0 .5em 0;
-	padding : 0;
-}
-
-#submenu ul {
-	margin : 0;
-	padding : 0;	
-}
-
-#submenu ul li {
-	padding-left : 0;
-}
-
 table {
 	border-collapse : collapse;
 	border-top : 1px solid #BCBCBC;
@@ -330,10 +279,6 @@ td.od {
 	font-weight : bold;
 }
 
-tr.warn td {
-	background-color: #FF9090;
-}
-
 tr.onissue td {
 	background-color: #FFFFCC;
 }
@@ -357,13 +302,6 @@ caption {
 	margin : .3em 0;
 }
 
-span.problem {
-	background-color : #FFFFCC;
-	color : #990000;
-	font-weight : bold;
-	line-height : 1.7em;
-}
-
 fieldset {
 	margin : 1em 1em 1em 0;
 	padding : 1em;
@@ -394,10 +332,6 @@ legend {
 	margin-top : 1em;
 }
 
-#commonsearch {
-	display : inline;
-}
-
 div.justify {
     text-align: justify;
 }
@@ -413,17 +347,6 @@ div#header_search input {
 	font-size : 1.3em;
 }
 
-div#header_search ul.link-tabs {
-	font-family : Arial, Geneva, sans-serif;
-	margin-bottom : -4px;
-}
-
-div#header_search ul.link-tabs li.on a,
-div#header_search ul.link-tabs li a,
-div#header_search ul.link-tabs li.off a {
-	padding : 0.1em .5em .2em .5em;
-}
-
 div#header_search div.residentsearch {
 	border : 0;
     border-bottom : 1px solid #85ca11;
@@ -532,7 +455,7 @@ div.patroninfo ul li {
 	margin : 0;
 }
 
-div.patroninfo ul li, div.patronviews ul li {
+div.patroninfo ul li {
 	list-style-type : none;
 }
 
@@ -542,6 +465,7 @@ div.patronviews {
 	margin-bottom : .5em;
 	padding : .5em 0 .5em 0;
 }
+}
 
 .column-tool {
 	font-size: 80%;
@@ -1009,10 +933,6 @@ tr.highlight th[scope=row] {
 	border-color : #BCBCBC;
 }
 
-tr.confirm td, tr.highlight.confirm td {
-	background-color : #ffbfbf;
-}
-
 #circ_circulation_issue label {
 	font-size: 105%;
 	font-weight : bold;
@@ -1368,14 +1288,6 @@ div#menu li.active a:hover {
     border-right: 0;
 }
 
-ul.error {
-	background : #ffffcc;
-	border : 1px solid #ff9090;
-	margin : .5em;
-	padding : .5em .5em .5em 1.5em;
-	width : 75%
-}
-
 h1#logo {
 	border:0pt none;
 	float:left !important;
@@ -1725,14 +1637,14 @@ ul#toplevelmenu li.more ul li a.yuimenuitemlabel {
 	padding: .2em 20px .2em 20px;
 }
 		
-ul#menu li a, ul#toplevelmenu li a {
+ul#toplevelmenu li a {
 	text-decoration : none;
 }
-ul#menu li ul li, ul#toplevelmenu li ul li {
+ul#toplevelmenu li ul li {
 	display :block;
 	padding :0;
 }
-ul#menu li ul li a, ul#toplevelmenu li ul li a {
+ul#toplevelmenu li ul li a {
 	text-decoration : none;
 }
 
@@ -1907,20 +1819,6 @@ span.permissiondesc {
 	color: black;
 }
 
-.hintsClass {
-    font-family: tahoma, verdana, arial;
-    font-size: 12px;
-    background-color: #f0f0f0;
-    color: #000000;
-    border: 1px solid #808080;
-    padding: 5px;
-}
-.hintSource {
-    color: green;
-    text-decoration: underline;
-    cursor: pointer;
-}
-
 #cartDetails {
 	background-color : #FFF;
 	border: 1px solid #739acf;
@@ -2068,26 +1966,6 @@ fieldset.rows+h3 {clear:both;padding-top:.5em;}
     margin: 0;
 }
 
-.advsearch fieldset {
-    border : 1px solid #EEE;
-    -moz-border-radius : 3px;
-    border-radius : 3px;
-}
-
-.advsearch fieldset.action {
-    border : 0;
-}
-
-.advsearch fieldset fieldset {
-    border : 1px solid #EEE;
-    margin : 0;
-    padding : .3em .5em;
-    -moz-border-radius : 0;
-    border-radius : 0;
-}
-.advsearch fieldset fieldset+fieldset {
-    border-top : 0;
-}
 .advsearch table {
     border-spacing : 5px;
     border-collapse : separate;
-- 
1.7.9.5



More information about the Koha-patches mailing list