[Koha-patches] [PATCH] Bug 8952 - Add http:// to url in social media links on opac-detail
Owen Leonard
oleonard at myacpl.org
Wed Oct 24 18:39:06 CEST 2012
This patch adds a variable to the template, "protocol" based on
whether "using_https" is set. The appropriate protocol is
inserted before social media links.
To test, confirm that OPACBaseURL is set and lacks "http(s)://"
Social media links should include correct URLs.
A follow-up patch could copy use of this [% protocol %] variable
in other parts of this template which duplicate large chunks of
HTML based on [% using_https %].
---
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
index 3ecdc27..22b2367 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
@@ -1,5 +1,9 @@
[% USE KohaDates %]
-
+[% IF ( using_https ) %]
+ [% SET protocol = "https://" %]
+[% ELSE %]
+ [% SET protocol = "http://" %]
+[% END %]
[% INCLUDE 'doc-head-open.inc' %][% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Details for: [% title |html %][% FOREACH subtitl IN subtitle %], [% subtitl.subfield |html %][% END %]
[% INCLUDE 'doc-head-close.inc' %]
<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.tablesorter.min.js"></script>
@@ -1214,11 +1218,11 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
[% IF ( SocialNetworks ) %]
<div id="social_networks">
<span>Share</span>
- <div><a id="facebook" href="http://www.facebook.com/sharer.php?u=[% current_url |url %]&t=[% title |url %]" title="Share on Facebook">Facebook</a></div>
+ <div><a id="facebook" href="http://www.facebook.com/sharer.php?u=[% protocol %][% current_url |url %]&t=[% title |url %]" title="Share on Facebook">Facebook</a></div>
<div><a id="twitter" href="http://twitter.com/share" title="Share on Twitter">Twitter</a></div>
- <div><a id="linkedin" href="http://www.linkedin.com/shareArticle?mini=true&url=[% current_url |url %]&title=[% title |url %]" title="Share on LinkedIn">LinkedIn</a></div>
- <div><a id="delicious" href="http://www.delicious.com/save?url=[% current_url |url %]&title=[% title |url %]" title="Share on Delicious">Delicious</a></div>
- <div><a id="email" href="mailto:?subject=[% title %]&body=[% title %] ([% current_url |url %])" title="Share by email">Email</a></div>
+ <div><a id="linkedin" href="http://www.linkedin.com/shareArticle?mini=true&url=[% protocol %][% current_url |url %]&title=[% title |url %]" title="Share on LinkedIn">LinkedIn</a></div>
+ <div><a id="delicious" href="http://www.delicious.com/save?url=[% protocol %][% current_url |url %]&title=[% title |url %]" title="Share on Delicious">Delicious</a></div>
+ <div><a id="email" href="mailto:?subject=[% title %]&body=[% title %] ([% protocol %][% current_url |url %])" title="Share by email">Email</a></div>
<div><g:plusone size="small"></g:plusone></div>
</div>
[% END %]
--
1.7.9.5
More information about the Koha-patches
mailing list