[Koha-patches] [PATCH] Bug 8761 Dont inadvertantly use slices
Colin Campbell
colin.campbell at ptfs-europe.com
Tue Sep 11 20:09:37 CEST 2012
Assignment to a single element slice is better written
as a scalar - This generates a compile time warning as it
can lead to odd behaviour see perldiag for details
This corrects some cases which were added in a recent
commit
---
C4/Circulation.pm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/C4/Circulation.pm b/C4/Circulation.pm
index 8bd53b9..273c6f3 100644
--- a/C4/Circulation.pm
+++ b/C4/Circulation.pm
@@ -982,16 +982,16 @@ sub CanBookBeIssued {
# Index points to the next value
my $restrictionyear = 0;
if (($take <= $#values) && ($take >= 0)){
- $restrictionyear += @values[$take];
+ $restrictionyear += $values[$take];
}
if ($restrictionyear > 0) {
if ( $borrower->{'dateofbirth'} ) {
my @alloweddate = split /-/,$borrower->{'dateofbirth'} ;
- @alloweddate[0] += $restrictionyear;
+ $alloweddate[0] += $restrictionyear;
#Prevent runime eror on leap year (invalid date)
- if ((@alloweddate[1] == 2) && (@alloweddate[2] == 29)) {
- @alloweddate[2] = 28;
+ if (($alloweddate[1] == 2) && ($alloweddate[2] == 29)) {
+ $alloweddate[2] = 28;
}
if ( Date_to_Days(Today) < Date_to_Days(@alloweddate) -1 ) {
--
1.7.12.146.g16d26b1
More information about the Koha-patches
mailing list