[Koha-patches] [PATCH] Bug 10049 [Alternate] Comments tab shows ( ) instead of ( 0 ) on translated templates
Owen Leonard
oleonard at myacpl.org
Mon Apr 15 15:47:46 CEST 2013
This patch is an alternate solution to the problem of "0" not appearing
on the comment tab in translated templates. It uses the Template Toolkit
option of specifying a default value for a variable:
[% reviews.size || 0 %]
This syntax is already in use elsewhere in the template.
Same test plan:
1) Make sure comments/reviews are activated
2) Find a record with 0 comments/reviews in the opac
3) The tab shows: Comments ( 0 )
4) Switch to any other languages.
5) Tab now shows: <translation of Comments> ( )
6) Apply patch
7) Check English templates stil work correctly
8) Rerun 'perl translate install <langcode>
9) Check display is now correct.
10) Also check that number shows correctly for records
with comments.
---
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
index 3c37bd1..a8dabf3 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
@@ -946,7 +946,7 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
</li>
[% END %]
[% IF ( reviewson ) %]
- <li id="tab_comments"><a href="#comments">Comments ( [% IF reviews.defined %][% reviews.size %][% ELSE %]0[% END %] )</a></li>
+ <li id="tab_comments"><a href="#comments">Comments ( [% reviews.size || 0 %] )</a></li>
[% END %]
[% IF ( NovelistSelectProfile ) %]
--
1.7.9.5
More information about the Koha-patches
mailing list