[Koha-patches] [PATCH] Bug 10664 : Software error in overdue_notices.pl if there is no active currency

[Srdjan]

From: Sophie Meynieux <sophie.meynieux at biblibre.com>

If there is no active currency, when running overdue_notices.pl you get a sofware error "Can't use an undefined value as a HASH reference" on GetCurrency() function call

With this patch, if there is no active currency, fines are formated by default 0,00 and notices are correctly generated.

Test plan :
- have at least one borrower with overdue that should trigger a notice
- verify that there is no active currency (Adminitration > Currency & Exchange rates)
- run misc/cronjobs/overdue_notices.pl -v -n (to get the notice directly on output)

=> without the patch you get the software error
=> with the patch, notices are correctly generated

If an active currency is defined, the script overdue_notices.pl runs the same with or without patch

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
 misc/cronjobs/overdue_notices.pl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl
index 5f285c0..04ccf5a 100755
--- a/misc/cronjobs/overdue_notices.pl
+++ b/misc/cronjobs/overdue_notices.pl
@@ -688,7 +688,8 @@ sub parse_letter {
         $tables{'branches'} = $p;
     }
 
-    my $currency_format = GetCurrency()->{currency};
+    my $currencies = GetCurrency();
+    my $currency_format = $currencies->{currency} if defined($currencies);
 
     my @item_tables;
     if ( my $i = $params->{'items'} ) {
-- 
1.8.1.2