[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10557: GetBooksellersWithLateOrders has an unused branch parameter
Srdjan
srdjan at catalyst.net.nz
Wed Jul 17 01:19:37 CEST 2013
From: Jonathan Druart <jonathan.druart at biblibre.com>
C4::Booksellers::GetBooksellersWithLateOrders has an unused parameter.
The $branch variable is never used in the routine.
Test plan:
Check that no behavior changes on the late orders page.
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
C4/Bookseller.pm | 4 ++--
acqui/lateorders.pl | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/C4/Bookseller.pm b/C4/Bookseller.pm
index 2471380..3e1454f 100644
--- a/C4/Bookseller.pm
+++ b/C4/Bookseller.pm
@@ -98,14 +98,14 @@ sub GetBookSellerFromId {
=head2 GetBooksellersWithLateOrders
-%results = GetBooksellersWithLateOrders($delay);
+%results = GetBooksellersWithLateOrders( $delay, $estimateddeliverydatefrom, $estimateddeliverydateto );
Searches for suppliers with late orders.
=cut
sub GetBooksellersWithLateOrders {
- my ( $delay, $branch, $estimateddeliverydatefrom, $estimateddeliverydateto ) = @_; # FIXME: Branch argument unused.
+ my ( $delay, $estimateddeliverydatefrom, $estimateddeliverydateto ) = @_;
my $dbh = C4::Context->dbh;
# FIXME NOT quite sure that this operation is valid for DBMs different from Mysql, HOPING so
diff --git a/acqui/lateorders.pl b/acqui/lateorders.pl
index 7c2b3f3..d732357 100755
--- a/acqui/lateorders.pl
+++ b/acqui/lateorders.pl
@@ -118,7 +118,7 @@ if ($op and $op eq "send_alert"){
}
}
-my @parameters = ( $delay, $branch );
+my @parameters = ( $delay );
push @parameters, $estimateddeliverydatefrom_dt
? $estimateddeliverydatefrom_dt->ymd()
: undef;
--
1.8.1.2
More information about the Koha-patches
mailing list