[Koha-patches] [PATCH] Bug 10595 - OpacTopissue page still accessible when system preference is turned off

[Srdjan]

From: Mirko Tietgen <mirko at abunchofthings.net>

When the syspref is turned off, the link is hidden but the page is still accessible. This patch checks the syspref and redirects to 404 if it is disabled.

Test plan:

Before applying the patch

Enable OpacTopissue
  Observe there is a link to opac-topissues.pl next to Advanced search etc.
  Follow that link, observe that opac-topissues.pl is loading
Disable OpacTopissue
  Observe the link is gone
  Manually open /koha/opac-topissues.pl and check that it is loading even though the feature is disabled

Apply patch

(OpacTopissue still diabled)
Manually open /koha/opac-topissues.pl and observe that you are being redirected to the 404 page.
Enable OpacTopissue
  Follow the link or manuall open opac-topissues.pl and check that it is working

Signoff the patch.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
 opac/opac-topissues.pl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/opac/opac-topissues.pl b/opac/opac-topissues.pl
index 96b0c8f..95291d0 100755
--- a/opac/opac-topissues.pl
+++ b/opac/opac-topissues.pl
@@ -40,6 +40,13 @@ plugin that shows a stats on borrowers
 =cut
 
 my $input = new CGI;
+
+# if OpacTopissue is disabled, leave immediately
+if ( ! C4::Context->preference('OpacTopissue') ) {
+    print $input->redirect("/cgi-bin/koha/errors/404.pl");
+    exit;
+}
+
 my $branches = GetBranches();
 my $itemtypes = GetItemTypes();
 
-- 
1.8.1.2