[Koha-patches] [PATCH] Bug 10258: Remove erroneous call to haspermission in basket.pl

[Srdjan]

From: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>

First parameter (userid) was not passed making the test useless.
Removed the test for now. Current behavior does not change.
Just adding the first parameter here does not make sense. Using the permission
here needs more than that.

Test plan:
Open a closed basket in Acquisition.
Check if you see all available basketgroups in the combo at the right side.

Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
 acqui/basket.pl | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/acqui/basket.pl b/acqui/basket.pl
index 7eff6e4..34e22c8 100755
--- a/acqui/basket.pl
+++ b/acqui/basket.pl
@@ -207,8 +207,12 @@ if ( $op eq 'delete_confirm' ) {
     }
 #if the basket is closed,and the user has the permission to edit basketgroups, display a list of basketgroups
     my ($basketgroup, $basketgroups);
-    my $member = GetMember(borrowernumber => $loggedinuser);
-    if ($basket->{closedate} && haspermission({ acquisition => 'group_manage'} )) {
+    # my $member = GetMember(borrowernumber => $loggedinuser);
+    # FIXME $member is not used in current code (BZ 10258)
+    # FIXME The following code should check the permission { acquisition => 'group_manage'}
+    # Removed an invalid call to haspermission for now. No behavior change.
+    # Only adding $member->{userid} is not the solution..
+    if ($basket->{closedate}) {
         $basketgroups = GetBasketgroups($basket->{booksellerid});
         for my $bg ( @{$basketgroups} ) {
             if ($basket->{basketgroupid} && $basket->{basketgroupid} == $bg->{id}){
-- 
1.8.1.2