[Koha-patches] [PATCH] [SIGNED-OFF] Bug 10291: Clarify misleading variable name
Srdjan
srdjan at catalyst.net.nz
Tue Jun 4 03:54:59 CEST 2013
From: Colin Campbell <colin.campbell at ptfs-europe.com>
Remove the unrequired extra processing and pass
the array of itemnumbers as itemnumbers_array
Signed-off-by: Srdjan <srdjan at catalyst.net.nz>
---
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt | 4 ++--
koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 4 ++--
tools/batchMod.pl | 3 +--
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
index 5404f02..292b81f 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-del.tt
@@ -119,8 +119,8 @@ for( x=0; x<allColumns.length; x++ ){
[% IF ( too_many_items ) %]
<p>Too many items ([% too_many_items %]) to display individually.</p>
- [% FOREACH itemnumbers_hashre IN itemnumbers_hashref %]
- <input type="hidden" name="itemnumber" value="[% itemnumbers_hashre.itemnumber %]" />
+ [% FOREACH itemnumber IN itemnumbers_array %]
+ <input type="hidden" name="itemnumber" value="[% itemnumber %]" />
[% END %]
[% END %]
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
index 01d0bc1..de67517 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
@@ -141,8 +141,8 @@ $(document).ready(function(){
[% IF ( too_many_items ) %]
<p>Too many items ([% too_many_items %]): not displaying each one individually.</p>
- [% FOREACH itemnumbers_hashre IN itemnumbers_hashref %]
- <input type="hidden" name="itemnumber" value="[% itemnumbers_hashre.itemnumber %]" />
+ [% FOREACH itemnumber IN itemnumbers_array %]
+ <input type="hidden" name="itemnumber" value="[% itemnumber %]" />
[% END %]
[% END %]<!-- /too_many_items -->
diff --git a/tools/batchMod.pl b/tools/batchMod.pl
index c299487..ec0ef01 100755
--- a/tools/batchMod.pl
+++ b/tools/batchMod.pl
@@ -261,8 +261,7 @@ if ($op eq "show"){
} else {
$template->param("too_many_items" => scalar(@itemnumbers));
# Even if we do not display the items, we need the itemnumbers
- my @itemnumbers_hashref = map {{itemnumber => $_}} @itemnumbers;
- $template->param("itemnumbers_hashref" => \@itemnumbers_hashref);
+ $template->param(itemnumbers_array => \@itemnumbers);
}
# now, build the item form for entering a new item
my @loop_data =();
--
1.8.1.2
More information about the Koha-patches
mailing list