[Koha-patches] [PATCH] Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff

[Owen Leonard]

The descriptions/title notes tab appears on the detail page in both
staff client and OPAC even if there are no notes. This is probably a
relic of the pre-T:T days when it wasn't possible to use || in an IF.
This patch adds a check for the various variables which might trigger
the display of the tab.

To test, apply the patch and view records in the OPAC and staff client
which do and do not have title notes attached (whether that be in the
MARC reocrd or in the biblio.notes column). In the OPAC Syndetics
content should also be tested if possible. The descriptions/title notes
tab should only appear if there is content.
---
 .../prog/en/modules/catalogue/detail.tt            |    8 ++++++--
 koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt |    8 +++++++-
 2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index d4b5272..d09b726 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -358,7 +358,7 @@ function verify_images() {
     [% ELSE %]
         <li><a href="#holdings">Holdings</a></li>
     [% END %]
-<li><a href="#description">Descriptions</a></li>
+[% IF ( MARCNOTES || notes ) %]<li><a href="#description">Descriptions</a></li>[% END %]
 [% IF ( subscriptionsnumber ) %]<li><a href="#subscriptions">Subscriptions</a></li>[% END %]
 [% IF ( FRBRizeEditions ) %][% IF ( XISBNS ) %]<li><a href="#editions">Editions</a></li>[% END %][% END %]
 [% IF ( LocalCoverImages ) %][% IF ( localimages || CAN_user_tools_upload_local_cover_images ) %]<li><a href="#images">Images</a></li>[% END %][% END %]
@@ -596,7 +596,9 @@ function verify_images() {
         [% END %]
     </div>
 [% END %]
-    
+
+[% IF ( MARCNOTES || notes ) %]
+
 <div id="description">
 <div class="content_set">
 
@@ -612,6 +614,8 @@ function verify_images() {
 </div>
 </div>
 
+[% END %]
+
 [% IF ( subscriptionsnumber ) %]
 <div id="subscriptions">
 <div class="yui-g">
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
index 1effd07..b516518 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
@@ -924,7 +924,9 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
     [% IF (SeparateHoldings) %]
         <li><a href="#otherholdings">Other holdings ( [% otheritemloop.size || 0 %] )</a></li>
     [% END %]
-<li id="tab_descriptions"> <a href="#descriptions">Title notes</a></li>
+[% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %]
+    <li id="tab_descriptions"> <a href="#descriptions">Title notes</a></li>
+[% END %]
 [% IF ( SYNDETICS_TOC ) %]
     <li id="tab_toc"> <a href="#toc">TOC</a></li>
 [% END %]
@@ -1062,6 +1064,8 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
     </div>
 [% END %]
 
+[% IF ( MARCNOTES || notes || ( SyndeticsEnabled && SyndeticsSummary && SYNDETICS_SUMMARY )) %]
+
 <div id="descriptions">
 <div class="content_set">
 
@@ -1089,6 +1093,8 @@ YAHOO.util.Event.onContentReady("furtherm", function () {
 </div>
 </div>
 
+[% END %]
+
 [% IF ( SyndeticsEnabled ) %]
 
 [% IF ( SyndeticsTOC ) %][% IF ( SYNDETICS_TOC ) %]
-- 
1.7.9.5