[Koha-patches] [PATCH] Bug 6837 - When AllowOnShelfHolds is OFF then holds on records with available items should not be possible

Barry Cannon barry at oslo.ie
Mon Nov 18 17:39:02 CET 2013


This patch corrects this bug. Allows holds when systempref is set to "Allow", disallows when set to "Don't Allow".
---
 koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc |    4 ----
 koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt  |    4 ----
 koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt          |    4 ----
 3 files changed, 12 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc
index 0f16f3a..634fb95 100644
--- a/koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc
+++ b/koha-tmpl/opac-tmpl/prog/en/includes/opac-detail-sidebar.inc
@@ -4,10 +4,6 @@
             [% IF ( RequestOnOpac ) %]
                 [% IF ( AllowOnShelfHolds ) %]
                     <li><a class="reserve" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% biblionumber %]">Place hold</a></li>
-                [% ELSE %]
-                    [% IF ( ItemsIssued ) %]
-                        <li><a class="reserve" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% biblionumber %]">Place hold</a></li>
-                    [% END %]
                 [% END %]
             [% END %]
         [% END %]
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt
index 2010cee..83d4a61 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results-grouped.tt
@@ -275,10 +275,6 @@ function highlightOn() {
 						[% IF ( opacuserlogin ) %]
 							[% IF ( AllowOnShelfHolds ) %]
                                 <a class="hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% GROUP_RESULT.biblionumber %]">Place hold</a><!-- add back when available 0 holds in queue-->
-							[% ELSE %]
-								[% IF ( GROUP_RESULT.itemsissued ) %]
-                                    <a class="hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% GROUP_RESULT.biblionumber %]">Place hold</a><!-- add back when available 0 holds in queue-->
-								[% END %]
 							[% END %]
 						[% END %]
 					[% END %]
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
index 9235b2b..5598ca1 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt
@@ -669,10 +669,6 @@ $(document).ready(function(){
                         [% IF ( opacuserlogin ) %]
                             [% IF ( AllowOnShelfHolds ) %]
                                 <a class="hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Place hold</a><!-- add back when available 0 holds in queue-->
-                            [% ELSE %]
-                                [% IF ( SEARCH_RESULT.itemsissued ) %]
-                                    <a class="hold" href="/cgi-bin/koha/opac-reserve.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Place hold</a><!-- add back when available 0 holds in queue-->
-                                [% END %]
                             [% END %]
                         [% END %]
                     [% END %]
-- 
1.7.10.4



More information about the Koha-patches mailing list