[Koha-patches] [PATCH] Bug 10983: Remove unused private subroutines from C4::Budgets

[Colin Campbell]

The subroutine _filter_fields is not used by the module
and the sub _columns is only used by it

Remove the dead code, and any associated bugs
---
 C4/Budgets.pm | 31 -------------------------------
 1 file changed, 31 deletions(-)

diff --git a/C4/Budgets.pm b/C4/Budgets.pm
index a648773..f3b82d4 100644
--- a/C4/Budgets.pm
+++ b/C4/Budgets.pm
@@ -956,37 +956,6 @@ sub ConvertCurrency {
     return ( $price / $cur );
 }
 
-=head2 _columns
-
-returns an array containing fieldname followed by PRI as value if PRIMARY Key
-
-=cut
-
-sub _columns(;$) {
-	my $tablename=shift||"aqbudgets";
-    return @{C4::Context->dbh->selectcol_arrayref("SHOW columns from $tablename",{Columns=>[1,4]})};
-}
-
-sub _filter_fields{
-	my $budget=shift;
-	my $tablename=shift;
-    my @keys; 
-	my @values;
-	my %columns= _columns($tablename);
-	#Filter Primary Keys of table
-    my $elements=join "|",grep {$columns{$_} ne "PRI"} keys %columns;
-	foreach my $field (grep {/\b($elements)\b/} keys %$budget){
-		$$budget{$field}=format_date_in_iso($$budget{$field}) if ($field=~/date/ && $$budget{$field} !~C4::Dates->regexp("iso"));
-		my $strkeys= " $field = ? ";
-		if ($field=~/branch/){
-			$strkeys="( $strkeys OR $field='' OR $field IS NULL) ";
-		}
-		push @values, $$budget{$field};
-		push @keys, $strkeys;
-	}
-	return (\@keys,\@values);
-}
-
 END { }    # module clean-up code here (global destructor)
 
 1;
-- 
1.8.3.1