[Koha-patches] [PATCH] Bug 11034 Remove incorrect return for BiblioAutoLink

Colin Campbell colin.campbell at ptfs-europe.com
Thu Oct 10 15:18:30 CEST 2013


BiblioAutoLink was being called expecting an array to
be returned. The subroutine in fact returns a scalar

As the variables that the return was stored in, went
out of scope immediately. It is probably better to be
explicit that we are throwing the return away by not
going through the motions of storing it in a variable
---
 cataloguing/addbiblio.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl
index cb40396..bfb62f0 100755
--- a/cataloguing/addbiblio.pl
+++ b/cataloguing/addbiblio.pl
@@ -865,7 +865,7 @@ if ( $op eq "addbiblio" ) {
         my $oldbibnum;
         my $oldbibitemnum;
         if (C4::Context->preference("BiblioAddsAuthorities")){
-          my ($countlinked,$countcreated)=BiblioAutoLink($record,$frameworkcode);
+            BiblioAutoLink( $record, $frameworkcode );
         } 
         if ( $is_a_modif ) {
             ModBiblioframework( $biblionumber, $frameworkcode ); 
-- 
1.8.3.1



More information about the Koha-patches mailing list