[Koha-patches] [PATCH] Bug 11133 - Markup errors in OPAC place hold form HTML

Owen Leonard oleonard at myacpl.org
Fri Oct 25 16:43:33 CEST 2013


There are markup errors in the OPAC place hold form which prevent it
from validating successfully. These errors don't seem to cause any
visual problem but can potentially cause problems when debugging
template logic.

To test, apply the patch and validate the page using your preferred
validator (since it's a page which requires login you'll have to upload
or paste the source). The page should validate successfully. Test when
placing holds on:

- a single item
- multiple items
- items which you cannot place on hold
---
 .../opac-tmpl/prog/en/modules/opac-reserve.tt      |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
index bf334fa..671e1f9 100644
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-reserve.tt
@@ -460,8 +460,8 @@
                                 </li>
 
                             [% END %]
-                        [% END %]
                 </ul>
+                        [% END %]
                   [% IF ( OPACItemHolds ) %]
                   [% IF ( bibitemloo.holdable ) %]
 
@@ -540,11 +540,12 @@
                         </table>
                     </div>
 
+                </fieldset>
+                  [% END %]<!-- OPACItemHolds -->
+
                   [% END %]<!-- bib_available -->
 
-                  [% END %]<!-- OPACItemHolds -->
             </div>
-                </fieldset>
                 [% END %]
 
               [% END %] <!-- if message -->
-- 
1.7.9.5


More information about the Koha-patches mailing list