[Koha-patches] [PATCH] Bug 11686 - "please note your reason here..." does not get translated

[Owen Leonard]

Through some quirk of the translation script a predefined value on a
text input is not properly translated even though the string appears in
the po file. On the suggestions form the problem can be solved by using
the HTML5 placeholder attribute.

To test you must have existing suggestions to manage. Apply the patch
and:

- Update a translation by running tranlsate update [language code]
- Install/reinstall the translation by running translate install
  [language code]

- In the English templates:

  - Navigate to Acquisitions -> Suggestions and find the "Mark selected
    as:" section below the table of existing suggestions.
  - Select "Other" from the "choose a reason" field. A text input field
    should appear with the placeholder text "please note your reason
    here."

- In the templates you updated and installed, follow the same procedure
  above. The placeholder text should now appear with the correct
  translation.
- In both English and translated templates using this bulk-status option
  should save your chosen status correctly with the correct reason,
  whether that reason be predefined or manually entered.
---
 .../prog/en/modules/suggestion/suggestion.tt       |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
index cd5b958..046fc40 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
@@ -73,7 +73,6 @@ $(document).ready(function() {
         e.preventDefault();
 	});
 	$("#other_reason[% suggestion.suggestiontype %]").hide();
-    $("input[name*=other_reason[% suggestion.suggestiontype %]]").focus(function(){ $(this).val(""); });
     $("#reason[% suggestion.suggestiontype %]").change(function(){
 	    if($(this).val() == "other"){
 			$(this).hide();
@@ -575,7 +574,7 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o
             </select>
 
             <span id="other_reason[% suggestion.suggestiontype %]">
-                <input type="text" size="31" id="select-other_reason[% suggestion.suggestiontype %]" name="other_reason[% suggestion.suggestiontype %]" value="please note your reason here..." />
+                <input type="text" size="31" id="select-other_reason[% suggestion.suggestiontype %]" name="other_reason[% suggestion.suggestiontype %]" placeholder="please note your reason here..." />
                 <a href="#back[% suggestion.suggestiontype %]">Cancel</a>
             </span>
 
-- 
1.7.9.5